Bug 195664
| Summary: | dns/dnscrypt-proxy: Update to 1.4.2 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | lightside <lightside> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | amdmi3, freebsd, pi, riggs | ||||||||||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
lightside
2014-12-04 01:17:00 UTC
Created attachment 150165 [details]
The poudriere testport log (FreeBSD 10 amd64)
Created attachment 150171 [details] Proposed patch (with changed pkg-descr file) Added version of the patch with changed pkg-descr file. The description is from http://dnscrypt.org site. CC maintainer Created attachment 150172 [details]
Proposed patch (with additions and changes)
Added LICENSE_FILE.
Awaiting maintainer feedback. Also note that pkg-descr URLs which refer to a directory should end with a slash (Porters handbook, 3.2.1). No need to resend the patch. I did only little testing to see if upgrades from previous versions all go without anything unexpected for the user. But as far as I can see that works well; thank you very much. (approved) Warning from portlint: pkg-plist: [1]: @stopdaemon is deprecated. The pkg(8) has a generic mechanism to provide the same function, see HANDLE_RC_SCRIPTS in pkg.conf(5). @maintainer: Could you take a look? Created attachment 151197 [details] Proposed patch (with additions and changes) Hello, Thomas Zander. (In reply to Thomas Zander from comment #7) > Warning from portlint: > pkg-plist: [1]: @stopdaemon is deprecated. The pkg(8) has a generic > mechanism to provide the same function, see HANDLE_RC_SCRIPTS in pkg.conf(5). I guess, there is a need to just remove "@stopdaemon dnscrypt-proxy" from pkg-plist. Like the other commiters did, e.g. on the following svn revisions: 367015, 367016, 367085, 368912. Aha; I was using portlint 2.16.1 so didn't get that warning yet. Without "@stopdaemon dnscrypt-proxy" it's all fine to, but logically the daemon isn't stopped at "make deinstall" nor even at "pkg delete dnscrypt-proxy" as HANDLE_RC_SCRIPTS defaults to "false" instead of "YES", so -IMPO- the warning is a bit premature. But to stick with guidelines, then yes, the last patch is best. A commit references this bug: Author: pi Date: Sun Jan 4 09:46:54 UTC 2015 New revision: 376189 URL: https://svnweb.freebsd.org/changeset/ports/376189 Log: dns/dnscrypt-proxy: 1.4.0 -> 1.4.2 Changes: https://github.com/jedisct1/dnscrypt-proxy/releases PR: 195664 Submitted by: lightside@gmx.com Reviewed by: riggs Approved by: freebsd@dns-lab.com (maintainer) Changes: head/dns/dnscrypt-proxy/Makefile head/dns/dnscrypt-proxy/distinfo head/dns/dnscrypt-proxy/pkg-descr head/dns/dnscrypt-proxy/pkg-plist Committed, thanks. |
