Bug 19576

Summary: [patch] add magic to file(1) to recognise SID tunes
Product: Base System Reporter: benno <benno>
Component: miscAssignee: David E. O'Brien <obrien>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description benno 2000-06-29 15:00:01 UTC
file(1) does not currently recognise SID tunes.

Fix: Apply the following patch to usr.bin/file/Magdir/audio:
How-To-Repeat: 
run file on a SID tune file (.sid file)
Comment 1 alex 2000-06-29 15:16:06 UTC
Thus spake benno@netizen.com.au (benno@netizen.com.au):

> +
> +# Commodore 64 SID tunes
> +0	string		PSID		Commodore 64 SID tune

That is a little few:

alex:~ $ cat psid.txt ; file psid.txt
PSID AUDIO FORMAT
=================

The psid audio format is a nice thing.
psid.txt: Commodore 64 SID tune

Can't you extend this?

Alex
-- 
cat: /home/alex/.sig: No such file or directory
Comment 2 benno 2000-06-29 15:25:11 UTC
On Thu, Jun 29, 2000 at 04:16:06PM +0200, Alexander Langer wrote:
> Thus spake benno@netizen.com.au (benno@netizen.com.au):
> 
> > +
> > +# Commodore 64 SID tunes
> > +0	string		PSID		Commodore 64 SID tune
> 
> That is a little few:

[snip]
 
> Can't you extend this?

How about:

--- audio       Thu Jun 29 23:53:49 2000
+++ audio.new   Fri Jun 30 00:22:07 2000
@@ -94,3 +94,6 @@
 
 0      string          GF1PATCH110\0ID#000002\0        GUS patch
 0      string          GF1PATCH100\0ID#000002\0        Old GUS patch
+
+# Commodore 64 SID tunes
+0      string          PSID\0          Commodore 64 SID tune

I'd extend it further, but it seems to vary beyond that point.
If this isn't sufficient, I can actually go hunting for some sort of spec. =)

-- 
Benno Rice                                      "No, no. We're *sweet* and
XNFP Aries Dark Subculture-                      *innocent* evil bastards."
friendly Internet Geek
benno@netizen.com.au                                      "Defend your joy"
Comment 3 alex 2000-06-29 15:36:20 UTC
Thus spake Benno Rice (benno@netizen.com.au):

> +# Commodore 64 SID tunes
> +0      string          PSID\0          Commodore 64 SID tune
> I'd extend it further, but it seems to vary beyond that point.
> If this isn't sufficient, I can actually go hunting for some sort of spec. =)

Seems better, but go hunting :)

Alex

-- 
cat: /home/alex/.sig: No such file or directory
Comment 4 Sheldon Hearn 2000-06-29 15:46:54 UTC
On Thu, 29 Jun 2000 07:30:03 MST, Benno Rice wrote:

>  > Can't you extend this?
>  
>  How about:
>  
>  --- audio       Thu Jun 29 23:53:49 2000
>  +++ audio.new   Fri Jun 30 00:22:07 2000

Nonono.  We've been down the local modifications road and it isn't
pretty.  Please contact file(1)'s maintainer.  Having changes
incorporated into the official distribution is a much better idea, even
if it does take a little longer to filter into FreeBSD.

Ciao,
Sheldon.
Comment 5 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-03 21:14:39 UTC
Responsible Changed
From-To: freebsd-bugs->obrien

David promised to chat to the file(1) maintainer.
Comment 6 David E. O'Brien freebsd_committer freebsd_triage 2000-11-11 05:26:13 UTC
State Changed
From-To: open->closed

We have switched to the Christos Zoulas maintained version of `file'. 
Desired changes should be submitted to Christos.