Bug 195831

Summary: the mkisoimage.sh scripts always put a fstab file on generated images
Product: Base System Reporter: Kurt Lidl <lidl>
Component: miscAssignee: freebsd-bugs mailing list <bugs>
Status: New ---    
Severity: Affects Only Me CC: emaste
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
diffs to various mkisoimage.sh scripts none

Description Kurt Lidl freebsd_committer 2014-12-09 20:15:06 UTC
Created attachment 150407 [details]
diffs to various mkisoimage.sh scripts

When a release is generated, one of the steps near the end is typically
creation of bootable iso filesystems.  (Obviously, depending on exactly
what is being built.)

The different mkisoimage.sh scripts alway place a fstab file in the
generated iso filesystem - ideally this would only happen when generating
a bootable iso filesystem.

I've had a local patch for quite a while to change the behavior to only
generate the fstab files when the filesystem is bootable.  I use the same
mkisoimage.sh script to generate an upgrade.iso filesystem too, and that
isn't bootable, and should not have a fstab placed on it.

Anyhow, a patch to implement this is attached.
Comment 1 Ed Maste freebsd_committer 2015-01-13 01:24:17 UTC
It seems sensible to me to avoid putting /etc/fstab on non-bootable images so I agree the idea is sound.