Bug 195898

Summary: www/tomcat7 rc.d script does not honor forcestop and no longer kills tomcat (as in version 6)
Product: Ports & Packages Reporter: mike.jakubik
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed Overcome By Events    
Severity: Affects Many People CC: ler, vvd
Priority: ---    
Version: Latest   
Hardware: amd64   
OS: Any   

Description mike.jakubik 2014-12-11 20:21:02 UTC
Hello,

Hello,

I've Noticed that the rc.d script for tomcat7 has changed from version 6. In tomcat6 a function called tomcat_stop() would force kill after a certain timeout, this no longer happens in tomcat7 and sometimes we are unable to stop it using the rc.d script, it just sits there waiting for PID.

In tomcat6 we had:

tomcat_stop() {
        rc_pid=$(tomcat_check_pidfile $pidfile)

        if [ -z "$rc_pid" ]; then
                [ -n "$rc_fast" ] && return 0
                echo "${name} not running? (check $pidfile)."
                return 1
        fi

        echo "Stopping ${name}."
        ${java_command} stop
        tomcat_wait_max_for_pid ${tomcat%%TOMCAT_VERSION%%_stop_timeout} ${rc_pid}
        kill -KILL ${rc_pid} 2> /dev/null && echo "Killed."
        rm -f ${pidfile}
}


This function is no longer available in the version 7 rc.d script, is there any way it can be modified to function like in version 6? It was a great feature.

I also tried using forcestop but that doesn't seem to do anything different from stop, just sits waiting for PID.

Thank you.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-12-11 23:14:17 UTC
Fix summary and assign.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2017-04-08 14:37:53 UTC
AFAIK, this PR isn't actual anymore - rc.d scripts for tomcat* ports was rewritten completely.
mike.jakubik, can you test new rc.d script?
Comment 3 Larry Rosenman freebsd_committer freebsd_triage 2017-05-06 16:43:12 UTC
No longer needed.