Summary: | update to sysutils/lsof 4.89A is broken on 10.1-STABLE | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | rallenh | ||||||
Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||
Status: | Closed DUPLICATE | ||||||||
Severity: | Affects Only Me | CC: | david, diffie, gnome, junchoon, ler, riggs | ||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
rallenh
2014-12-18 18:53:57 UTC
Maintainers CC'd I also see this, running: FreeBSD g1-253.catwhisker.org 10.1-STABLE FreeBSD 10.1-STABLE #1416 r275898M/275898:1001504: Thu Dec 18 04:54:38 PST 2014 root@g1-253.catwhisker.org:/common/S1/obj/usr/src/sys/CANARY i386 with a ports tree that is a working copy as of r374890. Can any of the reporters or FreeBSD guys give Vic access to a i386 box? This DOES appear to be i386 specific, as my amd64 box does NOT exhibit this issue. Larry, e-mail me his pubkey... Done. Created attachment 150751 [details]
Quick fix patch for files/ directory
Storing attached file in sysutils/lsof/files/ fixes build for me.
stable/10 r275900 amd64.
Possibly breaks other branch/arch.
(In reply to Larry Rosenman from comment #4) > This DOES appear to be i386 specific, as my amd64 box does NOT exhibit this > issue. No. stable/10 r275900 amd64 is affected for me. Installing the patch in ports/sysutils/lsof/files also allowed lsof-4.89.a,8 to build & install for me -- today, running: FreeBSD g1-253.catwhisker.org 10.1-STABLE FreeBSD 10.1-STABLE #1417 r275933M/275935:1001504: Fri Dec 19 05:05:40 PST 2014 root@g1-253.catwhisker.org:/common/S1/obj/usr/src/sys/CANARY i386 with a ports working copy @374940. I will point vic here, but suspect his "official" fix will be something else. That said, I have no problem if a committer commits this. pr 196142 should fix this. (In reply to Larry Rosenman from comment #11) > pr 196142 should fix this. Unfortunately, not fixes for me. stable/10 r275926 amd64. (Updated base yesterday.) Needs including stdbool.h in dialects/freebsd/dlsof.h. Actually, looking in a bit further, including sys/types.h in my previous patch was overkill. Please note that possibly my patch would not be needed for branches / archs other than stable/10 amd64. (Not tested with other branches/archs.) Other solution but not recommended: Add typedef for bool somewhere in dialects/freebsd/dlsof.h instead of including stdbool.h. Reason: Typedef for type bool is missing. Possibly problem in base, as lsof was built fine before. (Cannot recall the revision.) Created attachment 150793 [details]
Updated quick fix patch for files/ directory
Including sys/types.h was overkill.
Possibly need adding version check for base.
*** This bug has been marked as a duplicate of bug 196142 *** (In reply to Tomoaki AOKI from comment #13) > Created attachment 150793 [details] > Updated quick fix patch for files/ directory > > Including sys/types.h was overkill. > Possibly need adding version check for base. This patch fixes build for me on amd64. Thanks! |