Bug 196116

Summary: [net80211] [patch]: export ieee80211_add_ssid symbol and remove local copy from if_iwn.c
Product: Base System Reporter: Andriy Voskoboinyk <avos>
Component: wirelessAssignee: freebsd-wireless (Nobody) <wireless>
Status: Closed FIXED    
Severity: Affects Only Me CC: adrian
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Make ieee80211_add_ssid() function public
none
Remove local copy of ieee80211_add_ssid none

Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2014-12-19 01:19:38 UTC
Created attachment 150741 [details]
Make ieee80211_add_ssid() function public

This should slightly reduce code duplication between net80211 stack and iwn / wpi drivers.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2014-12-19 01:21:06 UTC
Created attachment 150742 [details]
Remove local copy of ieee80211_add_ssid
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-12-19 01:40:45 UTC
A commit references this bug:

Author: adrian
Date: Fri Dec 19 01:40:00 UTC 2014
New revision: 275928
URL: https://svnweb.freebsd.org/changeset/base/275928

Log:
  Make ieee80211_add_ssid() public.

  Some drivers use private copies of this.

  PR:		kern/196116
  Submitted by:	Andriy Voskoboinyk <s3erios@gmail.com>

Changes:
  head/sys/net80211/ieee80211_output.c
  head/sys/net80211/ieee80211_proto.h
Comment 3 Adrian Chadd freebsd_committer freebsd_triage 2014-12-19 01:42:13 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-12-19 01:42:47 UTC
A commit references this bug:

Author: adrian
Date: Fri Dec 19 01:41:52 UTC 2014
New revision: 275929
URL: https://svnweb.freebsd.org/changeset/base/275929

Log:
  Remove a private copy of ieee80211_add_ssid().

  PR:		kern/196116
  Submitted by:	Andriy Voskoboinyk <s3erios@gmail.com>

Changes:
  head/sys/dev/iwn/if_iwn.c
Comment 5 bergerkos 2015-01-25 02:09:25 UTC
Comment on attachment 150741 [details]
Make ieee80211_add_ssid() function public

Thank you very much :)) This was breaking my build of iwn driver from 11.0-CURRENT within the 10.1-STABLE tree.