Bug 196122

Summary: [MAINTAINER] databases/mariadb100-server unbreak SSLv2 disabled exp-run
Product: Ports & Packages Reporter: Bernard Spil <brnrd>
Component: Individual Port(s)Assignee: Johannes Jost Meixner <xmj>
Status: Closed FIXED    
Severity: Affects Some People CC: Jungleboogie0, xmj
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195796
Bug Depends on:    
Bug Blocks: 195796    
Attachments:
Description Flags
Patch for databases/mariadb-server
none
patch for databases/mariadb-client
none
Patch for databases/mariadb100-server
none
Poudriere log of mariadb100-client amd64
none
Poudriere log of mariadb100-server amd64
none
Patch for databases/mariadb100-server
none
Poudriere log of mariadb100-server amd64
none
Poudriere log of mariadb100-client amd64
none
Patch for databases/mariadb100-server none

Description Bernard Spil freebsd_committer freebsd_triage 2014-12-19 12:57:09 UTC
Created attachment 150753 [details]
Patch for databases/mariadb-server

This came up during the SSLv2 disabled exp-run and through other reports. 
See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195796
and http://package18.nyi.freebsd.org/data/101amd64-default-PR195796/2014-12-12_06h28m13s/logs/errors/mariadb100-client-10.0.14.log

Error is
"===>  mariadb100-client-10.0.14 security/openssl package is installed. To build this either select the OPENSSL and PORTSSL options or deinstall openssl.
*** Error code 1"

Looks like this handling of OPENSSL options was old. Reworked it and built client without SSL, with bundled SSL, with OpenSSL from base and LibreSSL from ports which is now auto-detected. Server built fine with default options linking LibreSSL.

Minor fix for the INNODB option that was coming up twice.
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2014-12-19 12:58:39 UTC
Created attachment 150754 [details]
patch for databases/mariadb-client

Align CONFLICTS handling with -server master
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2014-12-19 14:43:43 UTC
Created attachment 150765 [details]
Patch for databases/mariadb100-server

Slightly revised patch, remove nested conditional.
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2014-12-19 14:48:49 UTC
Created attachment 150766 [details]
Poudriere log of mariadb100-client amd64
Comment 4 Bernard Spil freebsd_committer freebsd_triage 2014-12-19 14:49:41 UTC
Created attachment 150767 [details]
Poudriere log of mariadb100-server amd64

gzipped... Original size 2.3MB
Comment 5 Bernard Spil freebsd_committer freebsd_triage 2015-01-14 20:25:22 UTC
Created attachment 151636 [details]
Patch for databases/mariadb100-server

1. Fixes the build without SSLv2 exp-run
2. Rework of the port to new OPTIONS helpers (-24 lines)
Comment 6 Bernard Spil freebsd_committer freebsd_triage 2015-01-14 20:26:55 UTC
Created attachment 151637 [details]
Poudriere log of mariadb100-server amd64
Comment 7 Bernard Spil freebsd_committer freebsd_triage 2015-01-14 20:27:57 UTC
Created attachment 151638 [details]
Poudriere log of mariadb100-client amd64
Comment 8 Johannes Jost Meixner freebsd_committer freebsd_triage 2015-01-15 11:18:25 UTC
I'll take it (maintainer timeout).
Comment 9 Bernard Spil freebsd_committer freebsd_triage 2015-01-15 12:43:51 UTC
Created attachment 151670 [details]
Patch for databases/mariadb100-server

Proper patch against ports/head (previous patch failed)
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-01-16 15:56:03 UTC
A commit references this bug:

Author: xmj
Date: Fri Jan 16 15:55:35 UTC 2015
New revision: 377185
URL: https://svnweb.freebsd.org/changeset/ports/377185

Log:
  databases/mariadb100-server: use options helpers

  - Use options helpers
  - Use GCC on i386 versions of FreeBSD later than 10.1-RELEASE

  PR:		196122
  Differential Revision:	https://reviews.freebsd.org/D1535
  Submitted by:	Bernard Spil <spil.oss@gmail.com>
  Approved by:	maintainer timeout (3 weeks)
  Approved by:	swills (maintainer)

Changes:
  head/databases/mariadb100-server/Makefile
Comment 11 Johannes Jost Meixner freebsd_committer freebsd_triage 2015-01-16 15:56:45 UTC
Committed, thanks!