Bug 196163

Summary: audio/fluidsynth: ALSA option breaks build [patch]
Product: Ports & Packages Reporter: Mikhail T. <freebsd-2024>
Component: Individual Port(s)Assignee: freebsd-multimedia (Nobody) <multimedia>
Status: Closed FIXED    
Severity: Affects Only Me CC: riggs
Priority: --- Flags: bugzilla: maintainer-feedback? (multimedia)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Fix alsa-driver none

Description Mikhail T. 2014-12-20 17:57:36 UTC
Enabling ALSA option breaks the build here (10.1/amd64):

FAILED: /usr/bin/cc  -DHAVE_CONFIG_H -Dlibfluidsynth_EXPORTS -O2 -pipe -march=opteron  -I/opt/include/portaudio2 -I/opt/include  -fstack-protector -fno-strict-aliasing -O2 -pipe -march=opteron  -I/opt/include/portaudio2 -I/opt/include  -fstack-protector -fno-strict-aliasing -fPIC -I. -Isrc -Isrc/drivers -Isrc/synth -Isrc/rvoice -Isrc/midi -Isrc/utils -Isrc/sfloader -Isrc/bindings -Iinclude -I/opt/include/glib-2.0 -I/opt/lib/glib-2.0/include -I/opt/include -I/opt/include/alsa -MMD -MT src/CMakeFiles/libfluidsynth.dir/drivers/fluid_alsa.c.o -MF src/CMakeFiles/libfluidsynth.dir/drivers/fluid_alsa.c.o.d -o src/CMakeFiles/libfluidsynth.dir/drivers/fluid_alsa.c.o   -c src/drivers/fluid_alsa.c

...
src/drivers/fluid_alsa.c:357:8: error: duplicate case value '-32'
  case -ESTRPIPE:
       ^
src/drivers/fluid_alsa.c:350:8: note: previous case defined here
  case -EPIPE:


Indeed, both EPIPE and ESTRPIPE are 32...
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-20 17:57:36 UTC
Auto-assigned to maintainer multimedia@FreeBSD.org
Comment 2 Mikhail T. 2014-12-20 18:12:13 UTC
Created attachment 150815 [details]
Fix alsa-driver

I submitted this patch upstream too:

    https://sourceforge.net/p/fluidsynth/tickets/135/

Drop into files/ ...
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-01-04 18:25:18 UTC
A commit references this bug:

Author: riggs
Date: Sun Jan  4 18:24:24 UTC 2015
New revision: 376263
URL: https://svnweb.freebsd.org/changeset/ports/376263

Log:
  Fix build failure with non-default ALSA option

  PR:		196163
  Submitted by:	mi@ALDAN.algebra.com
  MFH:		2015Q1

Changes:
  head/audio/fluidsynth/files/patch-src__drivers__fluid_alsa.c
Comment 4 Thomas Zander freebsd_committer freebsd_triage 2015-01-04 18:26:15 UTC
Committed, thanks!
Great that you have submitted upstream as well!