Bug 196167
| Summary: | update devel/qtcreator to newest release | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tobias Berner <tcberner> | ||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | Flags: | rakuco:
maintainer-feedback+
|
||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Tobias Berner
2014-12-20 21:07:46 UTC
Auto-assigned to maintainer kde@FreeBSD.org Thanks for the patch. As it is, it doesn't work; the patches in files/ do not apply anymore but have not been removed, and it fails `make check-plist': ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: /bin/buildoutputparser ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. I also think that all those changes to %%DATADIR%% in the plist are not necessary and only make the patch a lot bigger. Created attachment 151033 [details]
fix plist and install buildoutputparser
I hope this one is better.
# make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
Excellent, thanks. It seems to build fine on 11amd64, but it failed on 8.4-i386 because it requires USES=compiler:c++11-lib. And a few additional questions/items: * Please add back the seds to gnuplot and ant, as they are still needed. Maybe there are other as well, try grepping for "/usr/bin" in the code base. * Why did you remove the .desktop file? * I think the CONFIG="configure" part of QMAKE_ARGS is not necessary. It was added to the port long ago without any explanation. Created attachment 151263 [details]
v3 of the patch
ok, now the Desktop-Entry is back, sorry for dropping it.
I went through the files and check for /usr/bin -- only one file actually gets installed using #!/usr/bin/perl -- fixed using shebanfix.
Further I readded gnuplot/ant post-patch seds (...now with 100% more /bin).
Created attachment 151616 [details] use upstream patches This diff replaces the patch with the one from upstream and adds an other one: * https://codereview.qt-project.org/#/c/102701/ [new] * https://codereview.qt-project.org/#/c/102705/ [replaced] Thanks for the work. I'll commit your latest version with some small changes: * You've replaced the tabs in one of the DESKTOP_ENTRIES lines with spaces. * There's an extra empty line before DESKTOP_ENTRIES and another one before ".include <bsd.port.mk>". * I'm going to capitalize and end all comments with periods. * I'll remove a trailing whitespace in the SHEBANG_FILES line. A commit references this bug: Author: rakuco Date: Wed Jan 14 23:01:55 UTC 2015 New revision: 377057 URL: https://svnweb.freebsd.org/changeset/ports/377057 Log: Update to 3.3.0. A lot of patches can be removed, and the only ones left are backported from upstream. The port now uses Qt5 instead of Qt4, and should finally be MAKE_JOBS_SAFE. Other smaller changes: * The paths for gnuplot and ant in the sed calls in the Makefile were wrong, and have been fixed. * There was no explanation for why "CONFIG+=configure" was required in QMAKE_ARGS, so it has been removed. Huge thanks to Tobias Berner for working on this and following my picky suggestions! PR: 196167 Submitted by: Tobias C. Berner <tcberner@gmail.com> Changes: head/devel/qtcreator/Makefile head/devel/qtcreator/distinfo head/devel/qtcreator/files/patch-git-4ee78bf head/devel/qtcreator/files/patch-git-6556edf head/devel/qtcreator/files/patch-git_ac627bb77 head/devel/qtcreator/files/patch-src__shared__qbs__src__lib__parser__qmljs.g head/devel/qtcreator/files/patch-src__shared__qbs__src__lib__parser__qmljsparser_p.h head/devel/qtcreator/pkg-plist |
