Bug 196222
| Summary: | ports-mgmt/portlint: update after Perl's hierarchy change | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mathieu Arnold <mat> |
| Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | Flags: | marcus:
maintainer-feedback+
|
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Auto-assigned to maintainer marcus@FreeBSD.org This look good to you? http://www.marcuscom.com/cgi-bin/cvsweb.cgi/portlint/portlint.pl.diff?r1=1.344&r2=1.345&f=h (In reply to Joe Marcus Clarke from comment #2) > This look good to you? > > http://www.marcuscom.com/cgi-bin/cvsweb.cgi/portlint/portlint.pl.diff?r1=1. > 344&r2=1.345&f=h Maybe the first two could be swapped and the second be an else, no need to bug people about the path being bad twice if it's in PERL_ARCH as both will match. For the second, SITE_PERL does not have PERL_VER in it any more, so it'd need to be removed, and maybe a SITE_ARCH version with /mach/PERL_VER added before it. While I'm thinking of it, any reference to the ${STAGEDIR}${SITE_PERL} and ${STAGEDIR}${SITE_ARCH} is wrong and should be replaced by ${STAGEDIR}${PREFIX}/${SITE_PERL_REL} and ${STAGEDIR}${PREFIX}/${SITE_BASE_REL} respectively, because SITE_PERL and SITE_ARCH are LOCALBASE based and LOCALBASE does not exist in the staging area, only PREFIX does. I'm not sure I follow. I get what you're asking about the STAGE stuff, but I don't understand exactly what you're getting at about the SITE_PERL. I don't have PERL_VER with SITE_PERL anymore. Can you provide some pseudo-code at least to clarify? Thanks. (In reply to Joe Marcus Clarke from comment #4) > I'm not sure I follow. I get what you're asking about the STAGE stuff, but > I don't understand exactly what you're getting at about the SITE_PERL. I > don't have PERL_VER with SITE_PERL anymore. > > Can you provide some pseudo-code at least to clarify? Thanks. You have : if ($j =~ m'\${(?:LOCALBASE|PREFIX)}/lib/perl5/site_perl/\${PERL_VER}') { There is no .../site_perl/PERL_VER any more : $ perl -V:sitelib -V:sitearch sitelib='/usr/local/lib/perl5/site_perl'; sitearch='/usr/local/lib/perl5/site_perl/mach/5.18'; the first one is SITE_PERL, the second one is SITE_ARCH What about this: http://www.marcuscom.com/cgi-bin/cvsweb.cgi/portlint/portlint.pl.diff?r1=1.348&r2=1.346&f=h BTW, the other checks you mention are already there around line 1978. Yes, those look good, thanks :-) Changes committed, thanks! |
%%SITE_PERL%% now points to lib/perl5/site_perl, and %%PERL_ARCH%% to lib/perl5/site_perl/mach/PERL_VER line 576, it says to replace lib/perl5/site_perl/%%PERL_VER%% with %%SITE_PERL%%, should remove the %%PERL_VER%% part, and maybe add a check for /mach/PERL_VER -> %%SITE_ARCH%%. line 1961: it says to use ${SITE_PERL} instead of \${(?:LOCALBASE|PREFIX)}/lib/perl5/site_perl/\${PERL_VER} it is true for the LOCALBASE based one, but the PREFIX based one should be replace by ${PREFIX}/${SITE_PERL_REL}.