Bug 196226
| Summary: | s/#ifdef __BSD_VISIBLE/#if __BSD_VISIBLE/ | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Sergey Kandaurov <pluknet> | ||||
| Component: | kern | Assignee: | John Baldwin <jhb> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | asomers, jhb | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | CURRENT | Flags: | jhb:
mfc-stable11+
jhb: mfc-stable10+ |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | 223481 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
This will need an exp-run. Ironically, commit r189814 for shm.h used #ifdef for shm.h and #if for sem.h. A commit references this bug: Author: jhb Date: Tue Nov 14 23:50:31 UTC 2017 New revision: 325835 URL: https://svnweb.freebsd.org/changeset/base/325835 Log: Use #if instead of #ifdef for __BSD_VISIBLE tests. __BSD_VISIBLE is always defined and it's value instead needs to be tested via #if to determine if FreeBSD-specific APIs should be exposed. PR: 196226, 223481 (exp-run) Submitted by: pluknet MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D12977 Changes: head/sys/sys/aio.h head/sys/sys/shm.h A commit references this bug: Author: jhb Date: Tue Jan 23 18:22:42 UTC 2018 New revision: 328294 URL: https://svnweb.freebsd.org/changeset/base/328294 Log: MFC 325835: Use #if instead of #ifdef for __BSD_VISIBLE tests. __BSD_VISIBLE is always defined and it's value instead needs to be tested via #if to determine if FreeBSD-specific APIs should be exposed. PR: 196226 Changes: _U stable/10/ stable/10/sys/sys/aio.h stable/10/sys/sys/shm.h _U stable/11/ stable/11/sys/sys/aio.h stable/11/sys/sys/shm.h |
Created attachment 150906 [details] sigh, bugzilla wants this field filed in __BSD_VISIBLE is always defined from sys/cdefs.h As such, it should be fixed in several places. $ grep -r '^#ifdef __BSD_VISIBLE' sys/ sys/aio.h:#ifdef __BSD_VISIBLE sys/shm.h:#ifdef __BSD_VISIBLE