Bug 196260
| Summary: | [maintainer update] sysutils/slurm-hpc: Update to 14.11.2 (version scheme changed) | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jason W. Bacon <jwb> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Steven Kreuzer <skreuzer> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Some People | CC: | jrm, skreuzer | ||||||||||||||
| Priority: | --- | ||||||||||||||||
| Version: | Latest | ||||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 151430 [details]
Diff to update sysutils/slurm-hpc to 14.11.2
I foolishly didn't check here before attempting this as well. I've attached what I came up with in case it's helpful.
Two lines in the Makefile and changes to pkg-plists might be helpful. This way, you don't have to specify %%PORTDOCS%%%%DOCSDIR%%-14.11.2 in pkg-plist.
In the Makefile:
DOCSDIR= ${PREFIX}/share/doc/${PORTNAME}-${PORTVERSION}
PLIST_SUB= SLURM_VERSION=${PORTVERSION}
Then in pkg-plist just use, e.g., %%DOCSDIR%%/html/Slurm_Entity.pdf.
It passes all the tests in the porter's handbook, but I see two warnings with portlint.
WARN: Makefile: [50]: You may remove pkg-plist if you use PLIST_FILES and/or PLIST_DIRS.
WARN: Makefile: [62]: the options to USES are not sorted. Please consider sorting them.
Please note that I haven't fully tested this since I saw this before I was finished and I'm still new to slurm. Both daemons start and seem to be working, but /var/spool/slurmd must be created manually and the appropriate permissions must be set.
I'm not sure there's anything we can do about the plist warning. PLIST_FILES is modified based on OPTIONS. I somehow overlooked the USES warning: Thanks for pointing that out. pkg-plist is generated by make makeplist (or using ports-mgmt/genplist), so the DOCSDIR and PLIST_SUB variables won't really save any work. Thanks for pointing out the /var/spool/slurmd issue. I'll fix this in the next update, probably using pkg-install. Created attachment 151783 [details]
patch to update sysutils/slurm-hpc to 14.11.3
There was some confusion about maintaintership. If my patch for 14.11.3 is accepted, can you please return jwbacon@tds.net as the the maintainer. Created attachment 151828 [details] Patch to upgrade sysutils/slurm to 14.11.3 Use default tab width, provide a better example configuration file, and set the maintainer back to jwbacon@tds.net (confirmed through email). Created attachment 152287 [details]
Patch to upgrade sysutils/slurm to 14.11.3
Fix the hunk at the top of the Makefile that wasn't applying cleanly.
Created attachment 152290 [details]
New patch to 14.11.3
I don't have time right now to thoroughly test the significant changes in Joseph's 14.11.3 patch, so I added a new one that's more incremental and addresses some of Joseph's suggestions. This also adds a pkg-install script to create /var/log/slurm and /var/spool/slurmd.
A commit references this bug: Author: skreuzer Date: Wed Jan 28 14:04:55 UTC 2015 New revision: 378061 URL: https://svnweb.freebsd.org/changeset/ports/378061 Log: Update to version 14.11.3 PR: 196260 Changes: head/sysutils/slurm-hpc/Makefile head/sysutils/slurm-hpc/distinfo head/sysutils/slurm-hpc/files/patch-configure head/sysutils/slurm-hpc/files/patch-src-plugins-acct_gather_filesystem-lustre-acct_gather_filesystem_lustre.c head/sysutils/slurm-hpc/files/patch-src-plugins-select-cons_res-dist_tasks.c head/sysutils/slurm-hpc/files/patch-src-plugins-task-cgroup-task_cgroup_cpuset.c head/sysutils/slurm-hpc/files/pty.h head/sysutils/slurm-hpc/files/slurm.conf.example head/sysutils/slurm-hpc/files/slurm.conf.in head/sysutils/slurm-hpc/pkg-descr head/sysutils/slurm-hpc/pkg-plist |
Created attachment 150946 [details] Unified diff Update to latest stable version 14.11.2 (2014-Nov-rev2). Fix pty issue that prevented interactive jobs from working. Generate example configuration file from included example. Clean up port Makefile.