Bug 19631

On Sat, 01 Jul 2000 16:29:55 MST, fred@condo.chico.ca.us wrote:

> >Description:
> /etc/periodic/daily/400.disk-status runs daily and includes the output
> of df -k to show disk usage. Since modern disks are big, it is hard to
> read the disk sizes. It would be more readable to use the new df -h 
> option, which reports disk sizes in M and G.

The disadvantage of your proposed change is that folks who feed this
mail into scripts will have problems.  However, I'm certainly keen on
conditionalizing your change on a periodic.conf variable.

Ciao,
Sheldon.

Comment 2 Sheldon Hearn 2000-07-03 11:17:09 UTC

Responsible Changed
From-To: freebsd-bugs->sheldonh

I have time to look at this while I'm waiting for feedback 
on my conformance manual page improvements proposal.

Hi Brian,

Please check the following PR and then consider the patch below.

	http://www.freebsd.org/cgi/query-pr.cgi?pr=19631

Thanks,
Sheldon.

Index: etc/defaults/periodic.conf
===================================================================
RCS file: /home/ncvs/src/etc/defaults/periodic.conf,v
retrieving revision 1.5
diff -u -d -r1.5 periodic.conf
--- etc/defaults/periodic.conf	2000/06/30 09:41:15	1.5
+++ etc/defaults/periodic.conf	2000/07/03 10:20:39
@@ -81,6 +81,7 @@
 
 # 400.status-disks
 daily_status_disks_enable="YES"				# Check disk status
+daily_status_df_flags="-h -t nonfs"			# df(1) flags for check
 
 # 410.status-uucp
 daily_status_uucp_enable="YES"				# Check uucp status
Index: etc/periodic/daily/400.status-disks
===================================================================
RCS file: /home/ncvs/src/etc/periodic/daily/400.status-disks,v
retrieving revision 1.3
diff -u -d -r1.3 400.status-disks
--- etc/periodic/daily/400.status-disks	2000/06/23 01:18:23	1.3
+++ etc/periodic/daily/400.status-disks	2000/07/03 10:19:32
@@ -16,7 +16,7 @@
 	echo ""
 	echo "Disk status:"
 
-	df -k -t nonfs
+	df $daily_status_df_flags
 
 	# display which filesystems need backing up
 
Index: share/man/man5/periodic.conf.5
===================================================================
RCS file: /home/ncvs/src/share/man/man5/periodic.conf.5,v
retrieving revision 1.7
diff -u -d -r1.7 periodic.conf.5
--- share/man/man5/periodic.conf.5	2000/06/30 11:24:31	1.7
+++ share/man/man5/periodic.conf.5	2000/07/03 10:26:45
@@ -216,13 +216,24 @@
 .Dq YES
 if you want to run
 .Pa /etc/uuclean.daily .
-.it Ar daily_status_disks_enable
+.It Ar daily_status_disks_enable
 (bool) Set to
 .Dq YES
 if you want to run
-.Ic df -k -t nonfs
+.Xr df 1
+.Po
+with the arguments supplied in
+.Ar daily_status_df_flags
+.Pc
 and
 .Ic dump W .
+.It Ar daily_status_df_flags
+(str) Set to the arguments for the
+.Xr df 1
+utility when
+.Ar daily_status_disks_enable
+is set to
+.Dq YES .
 .It Ar daily_status_uucp_enable
 (bool) Set to
 .Dq YES

Comment 4 Sheldon Hearn 2000-07-03 11:30:51 UTC

Responsible Changed
From-To: sheldonh->brian

Over to the new periodic maintainer.

Comment 5 Sheldon Hearn 2000-07-05 11:47:57 UTC

State Changed
From-To: open->analyzed

I committed to HEAD a solution as proposed and have left this for  
Brian as a reminder to MFC when he sees fit.

Comment 6 Brian Somers 2000-09-24 14:40:01 UTC

State Changed
From-To: analyzed->closed

The change was MFC'd recently