Bug 196374

Summary: devel/cmake: OPTIONS menu shows up every time (pre.mk before OPTIONS)
Product: Ports & Packages Reporter: Tomoaki AOKI <junchoon>
Component: Individual Port(s)Assignee: freebsd-kde (group) <kde>
Status: Closed FIXED    
Severity: Affects Some People Keywords: easy, patch, patch-ready, regression
Priority: Normal Flags: rakuco: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for Makefile to fix. apply in devel/cmake directory. none

Description Tomoaki AOKI 2014-12-30 08:18:59 UTC
Created attachment 151104 [details]
Patch for Makefile to fix. apply in devel/cmake directory.

OPTIONS menu shows up every time devel/cmake is processed.
bsd.ports.pre.mk should NOT be included before OPTIONS items.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-30 08:18:59 UTC
Auto-assigned to maintainer kde@FreeBSD.org
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-12-30 09:49:01 UTC
Looks good, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-12-30 09:51:49 UTC
A commit references this bug:

Author: rakuco
Date: Tue Dec 30 09:51:00 UTC 2014
New revision: 375826
URL: https://svnweb.freebsd.org/changeset/ports/375826

Log:
  Include bsd.port.pre.mk after setting OPTIONS.

  r375798 made the OPTIONS prompt show up on every build because
  bsd.port.pre.mk was being included too early. Move the inclusion down one
  section.

  PR:		196374
  Submitted by:	Tomoaki AOKI <junchoon@dec.sakura.ne.jp>

Changes:
  head/devel/cmake/Makefile