Bug 196729

Summary: multimedia/gstreamer: Fix too late occurrence of USES=
Product: Ports & Packages Reporter: John Hein <jcfyecrayz>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Some People CC: multimedia, riggs
Priority: --- Keywords: easy, needs-qa, patch
Version: LatestFlags: bugzilla: maintainer-feedback? (multimedia)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fix too late USES= by replacing bsd.port.pre.mk with bsd.port.options.mk koobs: maintainer-approval? (multimedia)

Description John Hein 2015-01-14 17:01:03 UTC
Created attachment 151628 [details]
fix too late USES= by replacing bsd.port.pre.mk with bsd.port.options.mk

Adding USES settings after bsd.port.pre.mk causes some variables to be set too late (e.g., *_DEPENDS in Uses/gettext*.mk).  For example:

before (in current gstreamer port - 0.10.36_2):
make -V BUILD_DEPENDS
bison:/usr/ports/devel/bison gmake:/usr/ports/devel/gmake pkgconf:/usr/ports/devel/pkgconf /usr/local/bin/flex:/usr/ports/textproc/flex

after patch:
make -f Makefile -V BUILD_DEPENDS
/usr/local/bin/flex:/usr/ports/textproc/flex bison:/usr/ports/devel/bison gmake:/usr/ports/devel/gmake pkgconf:/usr/ports/devel/pkgconf msgfmt:/usr/ports/devel/gettext-tools


Note missing gettext-tools in dependency list before the fix.

Bumping PORTREVISION is debatable here, but if the package is not rebuilt, it can have incomplete dependencies (because of missed recording of devel/gettext-runtime in LIB_DEPENDS).  It's probably best to bump PORTREVISION, although I did not do so in the attached patch.
Comment 1 Bugzilla Automation freebsd_committer 2015-01-14 17:01:03 UTC
Auto-assigned to maintainer multimedia@FreeBSD.org
Comment 2 commit-hook freebsd_committer 2015-04-19 07:56:08 UTC
A commit references this bug:

Author: riggs
Date: Sun Apr 19 07:55:42 UTC 2015
New revision: 384267
URL: https://svnweb.freebsd.org/changeset/ports/384267

Log:
  - Fix BUILD_DEPENDS and LIB_DEPENDS with NLS (default OPTION)
  - Simplify OPTIONS handling
  - Pet portlint
  - Bump PORTREVISION

  PR:		196729
  Submitted by:	z7dr6ut7gs@snkmail.com
  Reviewed by:	riggs
  MFH:		2015Q2

Changes:
  head/multimedia/gstreamer/Makefile
  head/multimedia/gstreamer/pkg-plist
Comment 3 commit-hook freebsd_committer 2015-04-19 08:05:10 UTC
A commit references this bug:

Author: riggs
Date: Sun Apr 19 08:04:34 UTC 2015
New revision: 384269
URL: https://svnweb.freebsd.org/changeset/ports/384269

Log:
  MFH: r384267

  - Fix BUILD_DEPENDS and LIB_DEPENDS with NLS (default OPTION)
  - Simplify OPTIONS handling
  - Pet portlint
  - Bump PORTREVISION

  PR:		196729
  Submitted by:	z7dr6ut7gs@snkmail.com
  Reviewed by:	riggs
  Approved by:	portmgr (erwin)

Changes:
_U  branches/2015Q2/
  branches/2015Q2/multimedia/gstreamer/Makefile
  branches/2015Q2/multimedia/gstreamer/pkg-plist