Summary: | [emulators/snes9x-gtk] Won't build. PortAudio error. | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jordan Irwin <antumdeluge> | ||||||||||||||||||||||
Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||||||||||||||||||
Status: | Closed FIXED | ||||||||||||||||||||||||
Severity: | Affects Only Me | CC: | antumdeluge, koalative, riggs, root | ||||||||||||||||||||||
Priority: | --- | Keywords: | patch, patch-ready | ||||||||||||||||||||||
Version: | Latest | Flags: | root:
maintainer-feedback+
|
||||||||||||||||||||||
Hardware: | Any | ||||||||||||||||||||||||
OS: | Any | ||||||||||||||||||||||||
Attachments: |
|
Description
Jordan Irwin
2015-01-14 21:25:11 UTC
Maintainer CC'd Created attachment 151643 [details]
config.log for emulators/snes9x-gtk
Here is the build log.
Sorry, I meant to say "CONFIGURE log" in that last post. Created attachment 151646 [details]
Patch for Makefile that adds option to enable/disable PortAudio support
I patched the Makefile and added an option to disable/enable PortAudio. When PortAudio is disabled the Port builds.
This PR is long timed out. However, the maintainer listed in the port: root@cooltrainer.org I'm adding Nicole directly, maybe she doesn't know about the PR yet. Yeah, sorry, I never got an email about this PR. Thanks for the manual CC, John :) The patch to just disable Portaudio at build time looks fine but I'll take a look at the port this weekend and see if it can't be fixed for real. Created attachment 154179 [details]
Patch to clean up options and fix license
A more thorough patch to actually fix PortAudio instead of just disabling it. We should also install the license. The license terms forbid distribution for profit which means this should have been NO_CDROM. Fix it.
Created attachment 154180 [details]
Add snes9x to LEGAL
This also needs to be in LEGAL if we are NO_CDROM.
Created attachment 154181 [details]
Snes9x default options log
Poudriere testport with defaults
Created attachment 154182 [details]
Snes9x all options log
Poudriere testlog with all the extras
I personally tested PortAudio and it works fine now :) [nicole@emi#nicole] snes9x-gtk Sound buffer size: 8192 (2048 samples) PortAudio sound driver initializing... --> (OSS : /dev/dsp, latency 64ms)...OK borders don't fit within the image Map_LoROMMap Sound buffer size: 8192 (2048 samples) ALSA sound driver initializing... --> (Device: default)...OK --> (16-bit, Stereo, 32000hz, 64 ms)...OK Sound buffer size: 8192 (2048 samples) PulseAudio sound driver initializing... W: [(null)] caps.c: Normally all extra capabilities would be dropped now, but that's impossible because PulseAudio was built without capabilities support. --> (32000hz, 16-bit Stereo, 64ms)...OK Sound buffer size: 8192 (2048 samples) OSS sound driver initializing... --> (Device: /dev/dsp)...OK --> (Format: 16-bit)...OK --> (Stereo)...OK --> (Frequency: 32000)...OK --> (Buffer size: 8192 bytes, 64ms latency)...OK I'm promoting this maintainer-submitted, poudriere-tested patch set. Isn't this line in post install -@update-desktop-database supposed to look like this @-update-desktop-database ? which raises the follow up question: Is it actually needed? That came straight out of the FreeBSD GNOME docs a few years ago when I originally wrote this port. You can still see it in the "Desktop Database" section of https://www.freebsd.org/gnome/docs/porting.html I couldn't find mention of it in the porter's handbook but looking around turned up USES= desktop-file-utils which appears to be the modern way of doing the same thing. It's needed because the .desktop entry installed by this port contains new MIME type associations for ROM images supported by the emulator. https://svnweb.freebsd.org/ports/head/Mk/Uses/desktop-file-utils.mk Could you test whether you notice any regression when using USES=... and omitting the post-install? If there are none, we could omit the latter. Created attachment 154939 [details]
Patch to clean up options and fix license
Now with USES= desktop-file-utils
Created attachment 154940 [details]
Poudriere testport with USES= desktop-file-utils
No regression, lgtm
Created attachment 154946 [details]
Updated patch to clean up options and fix license
Two changes compared to the last version of the patch
- We need c++11 when alsa option is selected, otherwise it does not build on 9.3
- Since only three items are left for PLIST, I moved those into the Makefile
Let me know whether you approve of those changes.
Comment on attachment 154946 [details]
Updated patch to clean up options and fix license
lgtm :)
A commit references this bug: Author: riggs Date: Sun Mar 29 19:18:34 UTC 2015 New revision: 382621 URL: https://svnweb.freebsd.org/changeset/ports/382621 Log: Fix build errors with PortAudio and/or ALSA PR: 196735 Submitted by: antumdeluge@gmail.com (pr), root@cooltrainer.org (patch) Reviewed by: riggs Approved by: root@cooltrainer.org (maintainer) Changes: head/LEGAL head/emulators/snes9x-gtk/Makefile head/emulators/snes9x-gtk/pkg-plist |