Bug 196750

Created attachment 151665 [details]
The poudriere testport log (FreeBSD 10 amd64)

Created attachment 151666 [details]
Proposed patch (since 372709 revision)

Clarified regular expression of styles for grep.

Created attachment 151667 [details]
Proposed patch (since 372709 revision)

- Add NO_ARCH=yes, because there are no architecture specific files

Created attachment 151668 [details]
The poudriere testport log (FreeBSD 10 amd64)

Created attachment 152075 [details]
Proposed patch (since 372709 revision)

The PORTVERSION changed to 20100605, because of latest changes date of styles files/directories

Created attachment 152076 [details]
The poudriere testport log (FreeBSD 10 amd64)

Created attachment 152077 [details]
New proposed patch (since 372709 revision)

I think, the proposed method to download distfiles need to be changed, because of possibility of changes for *.tar.bz2 distfile archives. Looks like, they are autogenerated with changes to directory date and theme.cfg files, which might lead to different checksums in case of this.

In the attachment you could find different method to download, based on one distfile, which needs to be created and hosted. The problem is with hosting of such distfile. Need someone who could host it.

The creation of distfile is automated, with the same checksum each time, if there are no changes to styles of nightly tarball (some unimportant (e.g. the ${WRKSRC}/License file and ${WRKSRC} directory dates) changes of which are fixed on creation time of distfile).

The full cycle of update looks like follows:
# make create-distfile
# make copy-distfile makesum

Then MASTER_SITES of Makefile need to be changed to hosting site.

Created attachment 152078 [details]
The new poudriere testport log (FreeBSD 10 amd64)

(In reply to comment #7)
> The full cycle of update looks like follows

Of course, need to determine the PORTVERSION, based on changed date of ${WRKSRC} directory, after "make create-distfile" command, then rerun it again with "make recreate-distfile" command, but I did it already. The distinfo in new proposed patch will be correct, if there are no changes to styles of nightly tarball, before it could be hosted with different version. Otherwise, the PORTVERSION need to be fixed also.

Created attachment 152079 [details]
New proposed patch (since 372709 revision)

Added depends stage to create-distfile, because installed x11-wm/fluxbox port is needed to determine installed style directories, which needs to be removed from directories of created distfile.

(In reply to comment #10)
> which needs to be removed from directories of created distfile.

which needs to be removed from extracted directories of fetched nightly tarball, if to be precise. This leads to the need of possible re-creation of such distfile, in case of new fluxbox version with styles from http://tenr.de/styles/ or styles with the same directories.

Created attachment 152080 [details]
New proposed patch (since 372709 revision)

Changed WWW to http://tenr.de/styles/

Created attachment 152082 [details]
New proposed patch (since 372709 revision)

(In reply to comment #11)
> This leads to the need of possible re-creation of such distfile, in case of new fluxbox version

Thinking about this, I moved determination of installed style directories to pre-install stage. Now it looks like this:
===>  Staging for fluxbox-tenr-styles-pack-20100605
===>   fluxbox-tenr-styles-pack-20100605 depends on executable: fluxbox - found
===>  List of excluded style directories, installed by fluxbox:
BlueFlux Emerge arch bloe bora_black bora_blue bora_green carp
green_tea ostrich zimek_bisque zimek_darkblue zimek_green

The distfile contains all styles from http://tenr.de/styles/ site, but it should be created and hosted somewhere to be used in ports. The nightly tarball repackaged to ${DISTNAME}${EXTRACT_SUFX} and ${DISTNAME} for root directory of archive is also good (or might be adapted), but it could have different checksum, because of auto-generated nature of some files/directories, - the create-distfile stage does it automatically, while retain the same checksum.

In case of new fluxbox version, the PORTREVISION of current port should be bumped, then the ports/package system will determine the differences in styles automatically.

Created attachment 152083 [details]
The new poudriere testport log (FreeBSD 10 amd64)

Created attachment 152087 [details]
New proposed patch (since 372709 revision)

Returned value of DISTNAME to "tenr.de-styles-${PORTVERSION}" for consistency purposes with previous version. This also returns some portlint warning about hypen in PORTNAME, which could be ignored. The distinfo is re-generated.

If someone has access to http://freebsd.unixfreunde.de/sources/fluxthemes/ directory it could upload created distfile, then MASTER_SITES might be returned also. Perhaps, this is Martin Wilke (miwi@), the creator of port (which is not active for ports, currently).

Created attachment 152088 [details]
The new poudriere testport log (FreeBSD 10 amd64)

There are following new styles (about 75) between 20071215 and 20100605 versions, if this matters:
aluminium apples arch ash aurora bali bead bloe blueworks bora_black
bora_blue bora_green bora_olive bora_royal cambridge_blood camo2
carbonit carbonium_blue carbonium_green carbonium_orange carbonium_pink
carbonium_red carbonium_yellow carp clumsy_blue cobalt colonel
copola cup cursed darkmatter decade edwin eliteforce finetti floyd
ginfizz grapes green_tea greenworks icicle icicle_open invisible
java kodak limish medicus mute myDEFCON_1 myDEFCON_2 myDEFCON_3
myDEFCON_4 myDEFCON_5 myDEFCON_6 needles observe ostrich post royal
seaside shiniesky sunburn sunflower sunlense tec technotron teriaki
titan trinity tron2 underwater winestein zimek_bisque zimek_darkblue
zimek_green

Some of them in fluxbox styles already. There are no deleted styles.
This is about 373 styles in total:
http://tenr.de/styles/allstyles.php

If someone could upload the generated distfile to http://distcache.FreeBSD.org/ports-distfiles/ or different "permanent" location, please say about it here. Also, I can post the link to generated distfile from temporary location to email, on request.

Created attachment 152113 [details]
New proposed patch (since 372709 revision)

Ok, I managed to find a file hosting service with direct link to download. I set expiration status to "never", but if this will be the case, then the http://distcache.FreeBSD.org/ports-distfiles/ could be used after, as previous version, currently.

The proposed patch updated.

Created attachment 152118 [details]
New proposed patch (since 372709 revision)

Added some fixes.

Created attachment 152119 [details]
The new poudriere testport log (FreeBSD 10 amd64)

Created attachment 152599 [details]
New proposed patch (since 378468 revision)

The patch updated, after ports r378468 changes.

- Changed "-j" option to "-a" for tar command to auto-detect archive method, based on file extension (EXTRACT_SUFX)
- Added showing of checksum, after creation of distfile, which is useful to check possible update

Created attachment 152600 [details]
The poudriere testport log (FreeBSD 10 amd64)

I guess, this PR should be closed because of no interest from other people (for over about a year).

On the other note, the "create-distfile" makefile's target is still works and gives the same contents (on message date), but with different size of archive, when using /usr/bin/tar from FreeBSD 10.2 compared to 10, therefore different distinfo file may be created. The chosen file service provider (i.e. MASTER_SITES) doesn't work at the time of writing, which may create a need to use mentioned "create-distinfo" target and host distfile on other place.

This PR was closed.