Bug 197036
| Summary: | [patch] net/quagga make rc script conform to the Porter's Handbook guidelines | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Serhii (Sergey) Kozlov <skozlov> | ||||
| Component: | Individual Port(s) | Assignee: | Mathieu Arnold <mat> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(mat) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Auto-assigned to maintainer mat@FreeBSD.org Mmmm, I'm really not sure 5 seconds is enough. When using BGP, many routers won't send their routes before 30 or 60 seconds after the session is up in order to reduce flapping. A commit references this bug: Author: mat Date: Tue Feb 17 14:25:24 UTC 2015 New revision: 379163 URL: https://svnweb.freebsd.org/changeset/ports/379163 Log: Make quagga's rc script conform to the porter's handbook guidelines. PR: 197036 Submitted by: Kozlov Sergey Sponsored by: Absolight Changes: head/net/quagga/Makefile head/net/quagga/files/quagga.in |
Created attachment 152060 [details] The Patch Fix following bugs in rc script: 1. The "-d" flag must be in command_args, not the name_flags (Porter's Handbook 6.26.1.12) 2. Make the while loop related to quagga_wait_for finite (Porter's Handbook 6.26.1.16) 3. Make cosmetic changes to the variable's alignment in comments on the top