Summary: | [mips] lang/ocaml has no local asm code for mips | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Sean Bruno <sbruno> | ||||||
Component: | Individual Port(s) | Assignee: | Michael Grünewald <michipili> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | emaste, imp, marino, michipili, mips | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(michipili) |
||||||
Version: | Latest | ||||||||
Hardware: | mips | ||||||||
OS: | Any | ||||||||
URL: | http://dirty.ysv.freebsd.org/data/11mips32-11mips32/2015-01-26_23h32m57s/logs/errors/ocaml-4.01.0_4.log | ||||||||
Attachments: |
|
Description
Sean Bruno
2015-01-27 17:12:49 UTC
Maintainer CC'd I am working on ocaml-4.02 [1] and will restrict the architecture for this version. If you think mips ASM could have been added, you can try the new port — that port seems to work correctly but I need more work to port labltk, which is now an independant package. [1]: See Bug 195736 Michael, I don't think you actually restricted the architecture in the end. Did you want to submit a patch to do that? I totally forgot about this. John, Could you assign the ticket to me so that I can see it in my bugs list? Thanks! Created attachment 157074 [details]
Mark the port broken under mips
This is a simple patch to mark the port broken on mips.
Is the hardware actually reported as "mips" by uname -m ?
I could not find a list of possible value for this and
the best I could achieve was to verify there is a mips
directory in /usr/src/sys.
I think this would be better: BROKEN_mips= fails to build due to the lack of ASM code for ${OCAML_ARCH} (assuming "mips" is the value of ${ARCH}) Created attachment 157075 [details]
Mark the port broken under mips
Here is a new version!
mips is very uncommon in ports. I've found two references to ARCH: mips and mips64. is mips even a supported arch? Which do we need to break? mips? mips64? both of them? Maybe "mips" is wrong in all cases and it's only "mips64" ? personally I think this PR is stuck until Bruno clears this up. Yes, let's wait for his feedback. I was not able to clear this up either. according to this document, mips is "Tier 3" support (experiment): https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/archs.html That's why it is not listed here: https://www.freebsd.org/where.html You can still have bugs in tier 3 stuff in the database. Support in ports is allowed. Besides, the document you cited is a bit dated and in need of a rewrite. mips is almost tier 2 these days, and the push in the ports tree Sean is doing is part of that effort. The problem is simply that ocaml doesn't have the right assembler goo. Until it does, we'll need to mark it as broken. And "which mips" doesn't matter. they are all broken since the assembler goo that's needed is completely absent. Hi Warner, thank you for your feedback! As you noticed from the thread, I am not familiar with mips but as far as I understand, the line — and therefore the attached patch — BROKEN_mips= fails to build due to the lack of ASM code for ${OCAML_ARCH} looks fine, right? Maybe you could give a short confirmation that this would appropriately solve the issue. Thanks! Esp. is there anything required for mips64? my understand is that warner was saying, indirectly, that you need both BROKEN_mips and BROKEN_mips64 defined. Apparently we are talking about 2 platforms here. If I misunderstood then maybe it would be easier in warner or bruno produced the patch. Sean, Warner, do you have any more thoughts on this topic? Would it solve the issue appropriately if we add a broken message for mips and mips64? If not, what would be the list of architectures? As silly as the question might look like, it is not that easy to find the list of mips architectures as understood by FreeBSD, the first really useful document I was able to find is https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156292&action=edit So it would really be nice to have a quick confirmation! (In reply to Michael Grünewald from comment #16) Yeah, mips & mips64 should be disabled and marked as broken for now. BROKEN_mips= No ASM Support For ${ARCH} BROKEN_mips64= No ASM Support for ${ARCH} FWIW I've started collecting arch-specific details at https://wiki.freebsd.org/EdMaste/ArchitectureSpecifics. There are actually 6 different MIPS archs, but I assume nobody has really tried ports builds on the less common ones at all. A commit references this bug: Author: marino Date: Fri May 29 13:58:13 UTC 2015 New revision: 387855 URL: https://svnweb.freebsd.org/changeset/ports/387855 Log: lang/ocaml: Set BROKEN on 2 new ARCHES The MIPS platforms can't build ocaml. Set it and rework the BROKEN for sparc64 while here. PR: 197127 Changes: head/lang/ocaml/Makefile there's no reason to put ${ARCH} in broken message because it's already set in IGNORE. This one is done (I reworked BROKEN for sparc64 while here) |