Bug 197162
| Summary: | [NEW PORT] net-mgmt/dhcp_probe: Detect DHCP servers on network | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kevin Hung <khung> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | pi, riggs | ||||||||||||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||||||||||||
| Version: | Latest | ||||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Kevin Hung
2015-01-29 02:26:04 UTC
Created attachment 152672 [details]
new shar
Created attachment 152673 [details]
poudriere log - 10.1 amd64
Created attachment 152674 [details]
poudriere log - 9.3 amd64
Created attachment 152675 [details]
poudriere log - 8.4 amd64
New shar and attached poudriere testport logs for 8.4, 9.3, and 10.1 (amd64 only). Fixed wrong argument order in rc.d script, typo in conf sample, and correct LICENSE order in Makefile. (In reply to khung from comment #5) I tried to build it using poudriere and it failed with: =======================<phase: check-sanity >============================ ===> dhcp_probe-1.3.0 License GPLv2 addl needs confirmation, but BATCH is defined. *** Error code 1 From what I see, the license is pretty much a combination of GPL2 and BSD3CLAUSE. Why is a explicit confirmation needed ? (In reply to Kurt Jaeger from comment #6) I'm not familiar with how FreeBSD ports treat licensing. From my understanding, there are additional licenses in the COPYING file in the source that say "redistribution of (binaries|source code) must include the above copyright notice". The file is also available online [1]. If we do not need to show the licenses to the end-user, I can change the Makefile to include auto-accept in LICENSE_PERMS_addl. [1] https://www.net.princeton.edu/software/dhcp_probe/COPYING.txt "include" means it should be included in the package, probably in the DOCS. That should be sufficient. Created attachment 153335 [details]
dhcp_probe.shar
Updated Makefile to auto-accept additional licenses and copy all license files to the DOCS.
This port always links to libpcap from the base system (even if pcap from ports is installed), so the LIB_DEPENDS on libpcap from ports is not needed. I would remove this dependency and commit if you approve. (In reply to Thomas Zander from comment #10) Thanks, I agree that LIB_DEPENDS on libpcap is not needed. You can go ahead and make the change unless you prefer that I upload a new shar. A commit references this bug: Author: riggs Date: Sat Mar 7 18:33:22 UTC 2015 New revision: 380712 URL: https://svnweb.freebsd.org/changeset/ports/380712 Log: Initial import of net-mgmt/dhcp_probe, a tool to discover DHCP and BootP servers on a network PR: 197162 Submitted by: khung@nullaxiom.com (maintainer) Changes: head/net-mgmt/Makefile head/net-mgmt/dhcp_probe/ head/net-mgmt/dhcp_probe/Makefile head/net-mgmt/dhcp_probe/distinfo head/net-mgmt/dhcp_probe/files/ head/net-mgmt/dhcp_probe/files/dhcp_probe.in head/net-mgmt/dhcp_probe/files/patch-Makefile.am head/net-mgmt/dhcp_probe/files/patch-extras-dhcp__probe.cf.sample head/net-mgmt/dhcp_probe/files/patch-src_bootp.c head/net-mgmt/dhcp_probe/files/patch-src_configfile.c head/net-mgmt/dhcp_probe/files/patch-src_configfile.h head/net-mgmt/dhcp_probe/files/patch-src_daemonize.c head/net-mgmt/dhcp_probe/files/patch-src_defs.h head/net-mgmt/dhcp_probe/files/patch-src_dhcp__probe.c head/net-mgmt/dhcp_probe/files/patch-src_dhcp__probe.h head/net-mgmt/dhcp_probe/files/patch-src_get__myeaddr.c head/net-mgmt/dhcp_probe/files/patch-src_get__myeaddr.h head/net-mgmt/dhcp_probe/files/pkg-message.in head/net-mgmt/dhcp_probe/pkg-descr head/net-mgmt/dhcp_probe/pkg-plist (In reply to khung from comment #11) Nah, no worries, no new shar needed. Committed, thanks! Enjoy maintaining! |
