Bug 197175

Summary: [PATCH] update chinese/bitchx to work with irc/bitchx 1.2.1
Product: Ports & Packages Reporter: Anonymous <freebsd>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: dan.mashal, freebsd
Priority: --- Flags: bugzilla: maintainer-feedback? (dan.mashal)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch file
none
new patch freebsd: maintainer-approval+

Description Anonymous 2015-01-29 15:09:24 UTC 
Created attachment 152337 [details]
patch file

Allow for use with latest version of BitchX-1.2.1
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-29 15:09:24 UTC 
Maintainer CC'd
Comment 2 John Marino freebsd_committer freebsd_triage 2015-02-02 17:00:45 UTC 
This is failing badly now, so if the patch works I'm going to commit it (without waiting for maintainer)
Comment 3 John Marino freebsd_committer freebsd_triage 2015-02-02 17:15:09 UTC 
This patch appears untested.

muscles# make -V PORT_OPTIONS
make: "/build/boomdata/ports/potential/chinese/bitchx/Makefile" line 15: Malformed conditional (${PORT_OPTIONS:MLATIN})
make: Fatal errors encountered -- cannot continue
make: stopped in /build/boomdata/ports/potential/chinese/bitchx

A very similar message appears on FreeBSD 9.

I don't see how PORT_OPTIONS could even be checked at this point -- it's before bsd.options.mk is loaded.


Please take this PR back.  You probably have to patch irc/bitchx in order to fix the LATIN option on this port.
Comment 4 Anonymous 2015-02-02 21:52:15 UTC 
Created attachment 152495 [details]
new patch

This patch sets LATIN default which should fix the issue, as this should auto add in LATIN support even if user x using irc/bitchx set it to off.
Comment 5 Anonymous 2015-02-02 21:53:15 UTC 
Issues should be fixed now, I added in the wrong patch.
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2015-02-07 09:07:57 UTC 
Did you mean OPTIONS_SLAVE instead of OPTIONS_DEFAULT ?  OPTIONS_DEFAULT+= doesn't have any effect in your patch
Comment 7 Anonymous 2015-02-08 09:55:18 UTC 
I don't see OPTIONS_SLAVE in porters handbook?
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-02-08 13:33:57 UTC 
A commit references this bug:

Author: antoine
Date: Sun Feb  8 13:33:53 UTC 2015
New revision: 378654
URL: https://svnweb.freebsd.org/changeset/ports/378654

Log:
  Unbreak

  PR:		197175

Changes:
  head/chinese/bitchx/Makefile
  head/chinese/bitchx/files/patch-include__config.h
Comment 9 Antoine Brodin freebsd_committer freebsd_triage 2015-02-08 13:34:50 UTC 
For slave ports,  OPTIONS_SLAVE and OPTIONS_EXCLUDE should be use to unconditionnaly enable/disable an options from the master port.