Bug 197184

Summary: x11/libxkbfile: fix build with clang 3.6.0
Product: Ports & Packages Reporter: Dmitry Marakasov <amdmi3>
Component: Individual Port(s)Assignee: freebsd-x11 (Nobody) <x11>
Status: Closed FIXED    
Severity: Affects Only Me CC: kwm
Priority: --- Flags: bugzilla: maintainer-feedback? (x11)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 197395    
Attachments:
Description Flags
Patch
none
Full build log none

Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-29 19:53:37 UTC 
Created attachment 152348 [details]
Patch

I'm testing ports building on experimental projects/clang360-import branch, and libxkbfile fails there because of more strict warnings of clang 3.6:

---
===>  Building for libxkbfile-1.0.8_2
/usr/bin/make  all-recursive
Making all in src
  CC     cout.lo
cout.c:48:46: error: address of array 'xkb->names->vmods' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
    if ((!xkb)||(!xkb->names)||(!xkb->names->vmods))
                                ~~~~~~~~~~~~~^~~~~
1 error generated.
*** Error code 1
---

The vmods member is really an array, so the warning is valid. The fix is to remove the useless check. It was already fixed upstream:

http://cgit.freedesktop.org/xorg/lib/libxkbfile/commit/?id=9fa04388dcbb5bf205319569f540a62c03754688
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-29 19:53:37 UTC 
Auto-assigned to maintainer x11@FreeBSD.org
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-30 17:28:25 UTC 
Created attachment 152382 [details]
Full build log
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-30 17:32:00 UTC 
Oops, please disregard the log. It was for 197201
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-03 18:55:24 UTC 
A commit references this bug:

Author: kwm
Date: Tue Feb  3 18:54:28 UTC 2015
New revision: 378364
URL: https://svnweb.freebsd.org/changeset/ports/378364

Log:
  Add patch from upstream to fix the build with clang 3.6.

  PR:		197184
  Submitted by:	amdmi3@
  Obtained from:	libxkbfile upstream

Changes:
  head/x11/libxkbfile/files/
  head/x11/libxkbfile/files/patch-src_cout.c