Bug 197323
| Summary: | www/deforaos-surfer : Update to 0.2.7 (and fix break) | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | olivier | ||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||
| Severity: | Affects Some People | CC: | marino | ||||||||||||||||||
| Priority: | --- | Keywords: | patch-ready | ||||||||||||||||||
| Version: | Latest | ||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
Created attachment 152555 [details]
poudriere testport log file
There are 4 warnings in stage check:
Warning: 'bin/surfer' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'bin/download' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'bin/helper' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: you need USES=desktop-file-utils
Shouldn't all of these be fixed?
(In reply to John Marino from comment #2) It was the first time I see this "INSTALL_TARGET=install-strip" warning message: don't know how to fix them. And about the "USES=desktop-file-utils", I didn't see it (hidded in the others warning messages). I'm updating the port right now. (In reply to olivier from comment #3) The warning offers two ways how to fix them. BEST WAY) If the vendor makefile has the install-strip target, add this line to the port makefile "INSTALL_TARGET=install-strip" backup way) add a post-install target and use ${STRIP_CMD} to manually strip the binary in the stage dir. Use grep on the ports tree, there are probably hundreds of examples of this. Created attachment 152576 [details]
new patch for updating the port
Improved port with Q/A fixed: stripped binary and desktop-file-utils added.
Created attachment 152577 [details]
new poudriere testport log file
(In reply to John Marino from comment #4) And how to avoid to duplicate the list of by binary file twice ? Because I need to list them in ${STRIP_CMD} and in the plist file. I would have accepted the patch the "@" wasn't in front of ${STRIP_CMD}. We do not suppress command that occur in installation targets (with the exception of mkdir commands).
Also, you don't need to invoke STRIP_CMD three times, you can call it once with three arguments.
Please update the patch to at least remove the "@" symbol. You don't need to update the poudriere log, that looks fine.
(In reply to olivier from comment #7) I don't understand the question. You list it in post-install because the port fails to install stripped versions of the binary. The port-plist is just a manifest. Created attachment 152583 [details]
new-new patch for updating the port (the latest?)
I've listed the 3 files, but I can use a line like this one in place:
${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/*
yes, you can safely replace it with an asterisk. There are only 3 files in that bin directory, I believe, and all three need to be stripped. I'm ready to "promote" the PR, but I'll wait if you want to update the patch again. Created attachment 152592 [details]
new patch for updating the port
Port documentation re-enabled (software author prefer to do it).
Created attachment 152593 [details]
poudriere testport log file
This was almost fine. All these lines are very likely wrong: @dir share/icons/hicolor/24x24/apps @dir share/icons/hicolor/24x24 @dir share/icons/hicolor/16x16/apps @dir share/icons/hicolor/16x16 @dir share/icons/hicolor @dir share/icons The error message you probably saw wanted you to *remove* the @dirrmtry lines, not replace them with @dir. @dir is not a new name for @dirrm; it has a specific use and I don't think you are hitting that here. Please remove all these lines from pkg-plist and verify via poudriere that it still passes as expected. It's the only issue I see with the current patch. Created attachment 152601 [details]
new patch for updating the port
OMG… After 14 exchanges I'm still not able to provide a clean port :-(
Please, confirm this version is the good one… I'm starting a nervous breakdown :-)
The patch looks ok to me. Did you run it through poudriere again to verify that stage-qa phase passes? You don't need to upload a new log, I'll take your word for it. ( I think it will pass but it doesn't hurt to have confirmation ) (In reply to John Marino from comment #16) Yes poudriere seems totally happy: ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) ====>> Checking for staging violations... done okay, great! I know that was painful, but the PR just got promoted. :) crap, I got the PR wrong here too. I used the attachment ID again. Author: marino Date: Fri Feb 6 14:00:25 2015 New Revision: 378540 URL: https://svnweb.freebsd.org/changeset/ports/378540 QAT: https://qat.redports.org/buildarchive/r378540/ Log: www/deforaos-surfer: Upgrade version 0.2.6 => 0.2.7 (UNBREAK) PR: 152601 Submitted by: maintainer (Olivier Cochard) Added: head/www/deforaos-surfer/files/patch-ghtml-webkit.c (contents, props changed) head/www/deforaos-surfer/files/patch-src-download.c (contents, props changed) Deleted: head/www/deforaos-surfer/files/patch-doc__Makefile head/www/deforaos-surfer/files/patch-ghtml-webkit.diff Modified: head/www/deforaos-surfer/Makefile head/www/deforaos-surfer/distinfo head/www/deforaos-surfer/pkg-plist |
Created attachment 152554 [details] patch for updating the port Here is a maintainer update of deforaos-surfer to 0.2.7 and fix port breakage.