Bug 19733

Summary: GDB 4.18 is not GDB 4.18
Product: Base System Reporter: Andrew Cagney <cagney>
Component: gnuAssignee: Mark Peek <mp>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 3.4-RELEASE   
Hardware: Any   
OS: Any   

Description Andrew Cagney 2000-07-06 10:00:03 UTC
The GDB distributed with FreeBSD 3.4 (I suspect as do future and past
versions) prints the version information:

cagney@b1.cygnus.com$ which gdb
/usr/bin/gdb
cagney@b1.cygnus.com$ gdb
GNU gdb 4.18
Copyright 1998 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i386-unknown-freebsd".

Unfortunatly, that can't be correct.  GDB 4.18 doesn't even build on
FreeBSD 3.4 :-)

Fix: 

Can you please update the GDB version information in your GDB distro
so that it clearly and correctly identifies the program's heritage.  I
don't care what, just as long as it is clear to the user that the GDB
program isn't an off the shelf 4.18.  (Hmm, actually I do care a
little, please don't choose something like 4.18.1! :-).

	enjoy,
		Andrew

Andrew Cagney
GDB Maintainer
How-To-Repeat: 
Run GDB..
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 2000-07-06 12:15:35 UTC
Responsible Changed
From-To: freebsd-bugs->dfr

I _think_ Doug is the right person to handle this.
Comment 2 David E. O'Brien freebsd_committer freebsd_triage 2000-07-10 10:37:22 UTC
Responsible Changed
From-To: dfr->obrien

This is probably more for me.
Comment 3 David O'Brien 2000-07-10 10:42:10 UTC
>Unfortunatly, that can't be correct.  GDB 4.18 doesn't even build on
>FreeBSD 3.4 :-)

It does with some configureation tweaks.

>Can you please update the GDB version information in your GDB distro
>so that it clearly and correctly identifies the program's heritage.

"GNU gdb 4.18" does not do this?

>I don't care what, just as long as it is clear to the user that the GDB
>program isn't an off the shelf 4.18.  (Hmm, actually I do care a little,
>please don't choose something like 4.18.1! :-).

Why is this such an issue?
Comment 4 ac131313 2000-07-10 17:25:57 UTC
David O'Brien wrote:

> >Can you please update the GDB version information in your GDB distro
> >so that it clearly and correctly identifies the program's heritage.
> 
> "GNU gdb 4.18" does not do this?

It is GDB 4.18 + some configuration tweeks.

> >I don't care what, just as long as it is clear to the user that the GDB
> >program isn't an off the shelf 4.18.  (Hmm, actually I do care a little,
> >please don't choose something like 4.18.1! :-).
> 
> Why is this such an issue?

It isn't so much an ``issue'' as common sense :-).  Anyone doing a
patched GDB distro really should identify it as such. Otherwize no one
(least of all the person doing the distro) will know if a customers bug
is against that custom GDB distro, the GDB trunk, or even someone elses
custom GDB distro.  Just imagine, for a moment, what would happen if
everyone decided to do their own custom OS distribution and each one
contained a GDB with a slightly different set of patches ... ;-)

	Enjoy,
		Andrew
Comment 5 Sheldon Hearn freebsd_committer freebsd_triage 2002-01-30 13:33:52 UTC
Responsible Changed
From-To: obrien->mp

As stated in the audit trails of various other PRs, orbien is not 
the gdb maintainer.  Mark Peek is.
Comment 6 Sheldon Hearn 2002-01-30 13:42:06 UTC
Given that the GDB distribution maintainer asked us a year and a half
ago to change the version string in the binary we redistribute, we
really should have done it by now.

Mark, if Andrew's happy with this patch, please apply it so we can
forget about this.

Thanks,
Sheldon.

Index: alpha/version.c
===================================================================
RCS file: /home/ncvs/src/gnu/usr.bin/binutils/gdb/alpha/version.c,v
retrieving revision 1.1
diff -u -d -r1.1 version.c
--- alpha/version.c	2 May 1999 11:32:05 -0000	1.1
+++ alpha/version.c	30 Jan 2002 13:35:33 -0000
@@ -1,3 +1,3 @@
-char *version = "4.18";
+char *version = "4.18 (FreeBSD)";
 char *host_name = "alpha-unknown-freebsd";
 char *target_name = "alpha-unknown-freebsd";
Index: i386/version.c
===================================================================
RCS file: /home/ncvs/src/gnu/usr.bin/binutils/gdb/i386/version.c,v
retrieving revision 1.4
diff -u -d -r1.4 version.c
--- i386/version.c	2 May 1999 11:32:14 -0000	1.4
+++ i386/version.c	30 Jan 2002 13:35:43 -0000
@@ -1,3 +1,3 @@
-char *version = "4.18";
+char *version = "4.18 (FreeBSD)";
 char *host_name = "i386-unknown-freebsd";
 char *target_name = "i386-unknown-freebsd";
Comment 7 Mark Peek freebsd_committer freebsd_triage 2002-05-14 22:22:01 UTC
State Changed
From-To: open->closed

Change applied to both -current and -stable (for release with 4.6). Thanks.