Bug 197512

Summary: devel/gdb: Add support for GUILE
Product: Ports & Packages Reporter: Ashish SHUKLA <ashish>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Only Me CC: luca.pizzamiglio
Priority: --- Keywords: patch, patch-ready
Version: LatestFlags: koobs: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
devel/gdb diff
koobs: maintainer-approval+
Updated none

Description Ashish SHUKLA freebsd_committer 2015-02-10 11:57:25 UTC
Created attachment 152836 [details]
devel/gdb diff

Attached diff adds support for GUILE to the devel/gdb port. AFAICS, it works fine. Could you please approve the change ?

Thanks
Comment 1 Bugzilla Automation freebsd_committer 2015-02-10 11:57:25 UTC
Maintainer CC'd
Comment 2 luca.pizzamiglio 2015-02-11 10:40:21 UTC
Hi,
I shortly tested it and I approve.

thanks!

best regards,
pizzamig
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-02-11 10:43:12 UTC
Submitter is committer.
Comment 4 commit-hook freebsd_committer 2015-02-12 15:15:52 UTC
A commit references this bug:

Author: ashish
Date: Thu Feb 12 15:15:04 UTC 2015
New revision: 378879
URL: https://svnweb.freebsd.org/changeset/ports/378879

Log:
  - Add OPTION to enable support for GUILE

  PR:		197512
  Submitted by:	ashish
  Approved by:	<luca.pizzamiglio at gmail.com> (maintainer)

Changes:
  head/devel/gdb/Makefile
Comment 5 Ashish SHUKLA freebsd_committer 2015-02-12 15:16:40 UTC
Committed.

Thanks!
Comment 6 Ashish SHUKLA freebsd_committer 2015-02-25 06:27:43 UTC
Created attachment 153499 [details]
Updated

Hi Luca,

Sorry to re-open this PR. But I noticed, my previous diff missed installing GDB .scm files, similar to .py files required by Python support.

The attached diff fixes this. If you approve the change, then I could commit it.

Thanks
Ashish
Comment 7 Ashish SHUKLA freebsd_committer 2015-02-25 06:28:56 UTC
Open this PR to commit missing GUILE support stuff.
Comment 8 luca.pizzamiglio 2015-03-02 10:27:33 UTC
Hi Ashish,

Change approved, it works for me.
This update is a fix, so the port revision should be bumped.

thanks
Comment 9 commit-hook freebsd_committer 2015-03-02 12:47:02 UTC
A commit references this bug:

Author: ashish
Date: Mon Mar  2 12:46:40 UTC 2015
New revision: 380251
URL: https://svnweb.freebsd.org/changeset/ports/380251

Log:
  - Install missing files required for GUILE support

  PR:		197512
  Approved by:	Luca <luca.pizzamiglio at gmail.com> (maintainer)

Changes:
  head/devel/gdb/Makefile
  head/devel/gdb/pkg-plist
Comment 10 Ashish SHUKLA freebsd_committer 2015-03-02 12:48:43 UTC
Committed.

Thanks!