Bug 197574
| Summary: | [MAINTAINER] multimedia/cx88: Add missing load_rc_config call to cx88d | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | jason.harmening | ||||||||
| Component: | Individual Port(s) | Assignee: | Bartek Rutkowski <robak> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | brd, robak | ||||||||
| Priority: | --- | Keywords: | easy, needs-qa, patch | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Hi Jason, The patch helps, but does not bring the rc script fully up to date. Could you take a look at the following section in the handbook: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#rc-scripts I'd be happy to update it if you do not have the time. Regards, Brad DAvis Created attachment 152950 [details]
Updated patch
Cleanup cx88d, add support for per-device args, move to cx88d.in and obey SUB_LIST
Created attachment 152955 [details]
Updated patch (2)
Oops, left off some arg cleanup
(In reply to Brad Davis from comment #1) I've updated the script per the handbook, and cleaned up a few other things while I was there. A commit references this bug: Author: robak Date: Mon Mar 2 17:30:54 UTC 2015 New revision: 380277 URL: https://svnweb.freebsd.org/changeset/ports/380277 Log: multimedia/cx88: fix rc startup script PR: 197574 Submitted by: Jason Harmening <jason.harmening@gmail.com> Changes: head/multimedia/cx88/Makefile head/multimedia/cx88/files/ head/multimedia/cx88/files/cx88d.in head/multimedia/cx88/pkg-plist Committed, thanks for your work! |
Created attachment 152908 [details] the patch Allow "cx88d_enable" in rc.conf