Bug 197581

Summary: devel/psptoolchain-binutils creates directories for arm not armv6
Product: Ports & Packages Reporter: Sean Bruno <sbruno>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Some People CC: freebsd-arm, mikael, tphilipp
Priority: --- Keywords: needs-patch, needs-qa
Version: LatestFlags: bugzilla: maintainer-feedback? (tphilipp)
Hardware: arm   
OS: Any   
URL: http://chips.ysv.freebsd.org/data/11armv6-11armv6/2015-02-12_15h33m26s/logs/errors/psptoolchain-binutils-2.22_1.log
Attachments:
Description Flags
fix for armv6
none
Updated patch tphilipp: maintainer-approval+

Description Sean Bruno freebsd_committer freebsd_triage 2015-02-12 20:07:48 UTC 
This port fails at pkg creation time as it compiles and builds an arm-unknown-freebsd directory not an armv6-unknown-freebsd.

I suspect the configure script needs to be tweaked to change this.

Probably look at devel/binutils for a clue here.

https://svnweb.freebsd.org/ports/head/devel/binutils/Makefile?revision=378882&view=markup
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-12 20:07:48 UTC 
Maintainer CC'd
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-02-13 02:12:04 UTC 
[tags] in summary not needed when Hardware field is set.
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2015-02-17 15:28:25 UTC 
Created attachment 153109 [details]
fix for armv6

The attached patch should fix that.

root@armv6: make -V CONFIGURE_TARGET -C /usr/ports/devel/psptoolchain-binutils
arm-unknown-freebsd11.0

root@amd64: make -V CONFIGURE_TARGET -C /usr/ports/devel/psptoolchain-binutils
x86_64-unknown-freebsd11.0

I don't have an i386 machine to test...

build log for armv6:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/psptoolchain-binutils-2.22_1.log
Comment 4 Tassilo Philipp 2015-02-18 17:37:09 UTC 
Created attachment 153151 [details]
Updated patch

Thanks Mikael, I tested on amd64, and had to slightly tweak your patch, but it works fine. Find attached a new patch
Comment 5 Sean Bruno freebsd_committer freebsd_triage 2015-02-18 17:45:30 UTC 
(In reply to Tassilo Philipp from comment #4)
If you are ok with the patch, check the maintainer approved button on this bug and I'll commit it later today.
Comment 6 Tassilo Philipp 2015-02-18 20:19:12 UTC 
Comment on attachment 153151 [details]
Updated patch

approved
Comment 7 Sean Bruno freebsd_committer freebsd_triage 2015-02-20 16:55:11 UTC 
Comment on attachment 153109 [details]
fix for armv6

Obsoleted by maintainer.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-02-20 16:59:19 UTC 
A commit references this bug:

Author: sbruno
Date: Fri Feb 20 16:58:24 UTC 2015
New revision: 379449
URL: https://svnweb.freebsd.org/changeset/ports/379449

Log:
  Fix directory creation so that a armv6-unknown-freebsd directory is created
  instead of an arm-unkonwn-freebsd to be friendlier with freebsd pkg tools.

  PR:		197581
  Submitted by:	mikael.urankar@gmail.com
  Approved by:	tphilipp@potion-studios.com (maintainer)

Changes:
  head/devel/psptoolchain-binutils/Makefile