Summary: | games/cube: crashes when built with clang 3.6 + -O1 or higher | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | amdmi3, dim | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | amd64 | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Jan Beich
2015-02-13 22:38:05 UTC
Created attachment 152952 [details]
Fix invalid dereferencing of null reference
Yes, I can reproduce. This code is crazy, here is a patch to fix it.
Comment on attachment 152952 [details]
Fix invalid dereferencing of null reference
Works fine *with* the patch. Also tested no runtime regressions with gcc49 or within a jail of:
- 10.1R i386
- 10.0R amd64
- 9.3R i386
- 8.4R amd64
A commit references this bug: Author: jbeich Date: Fri Feb 20 06:53:39 UTC 2015 New revision: 379412 URL: https://svnweb.freebsd.org/changeset/ports/379412 Log: - Fix invalid dereferencing of null reference which causes startup crash for cube_client when built with clang 3.6 + -O1 or higher [1] - Properly track libenet dependency [2] PR: 197604 [1] PR: 197605 [2] Submitted by: dim [1] Changes: head/games/cube/Makefile head/games/cube/files/patch-entities.cpp head/games/cube/files/patch-physics.cpp head/games/cube/files/patch-protos.h head/games/cube/files/patch-rendermd2.cpp Tentatively closing unless other Cube ports may crash in similar way. For one, games/assaultcube has the warning (see bug 197582 comment 9) but doesn't crash. |