Bug 197609

Summary: security/cryptlib: builds on ARMv6 (Poudriere Powered)
Product: Ports & Packages Reporter: Vinícius Zavam <egypcio>
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed FIXED    
Severity: Affects Many People CC: egypcio, freebsd-arm, mikael, sbruno
Priority: --- Flags: bugzilla: maintainer-feedback? (ale)
Version: Latest   
Hardware: arm   
OS: Any   
Attachments:
Description Flags
cryptlib-3.4.1.log none

Description Vinícius Zavam freebsd_committer freebsd_triage 2015-02-14 03:34:48 UTC
Created attachment 152954 [details]
cryptlib-3.4.1.log

--- Makefile.orig
+++ Makefile
@@ -10,7 +10,7 @@ DISTNAME=             cl${PORTVERSION:S/.//g}
 MAINTAINER=            ale@FreeBSD.org
 COMMENT=               Powerful security programming toolkit
 
-ONLY_FOR_ARCHS=                i386 amd64
+ONLY_FOR_ARCHS=                i386 amd64 armv6
 
 OPTIONS_DEFINE=                DOCS
 
--- /dev/null
+++ files/patch-misc_os__spec.h
@@ -0,0 +1,13 @@
+--- misc/os_spec.h.orig        2015-02-13 18:19:47 UTC
++++ misc/os_spec.h
+@@ -606,9 +606,7 @@ typedef unsigned char              BYTE;
+    support for the change was added in gcc 4.4, so any newer version with 
+    ARM_EABI defined will have a scalar va_list */
+ 
+-#if defined( __GNUC__ ) && \
+-      ( ( __GNUC__ == 4 && __GNUC_MINOR__ >= 4 ) || ( __GNUC__ > 4 ) ) && \
+-      defined( __ARM_EABI__ )
++#if defined( __ARM_EABI__ )
+       /* In theory we could check __ap but in practice it's too risky to rely 
+          on the type and state of hidden internal fields, and in any case it's 
+          only a sanity check, not a hard requirement, so we just no-op the
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-14 03:34:48 UTC
Auto-assigned to maintainer ale@FreeBSD.org
Comment 2 Vinícius Zavam freebsd_committer freebsd_triage 2015-02-14 03:38:54 UTC
Patched by miki (#bsdmips@EFnet).
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2015-02-18 18:09:42 UTC
Can you attach a patch that:
 - merge files/patch-misc_os__spec.h and files/patch-misc_os_spec.h into files/patch-misc_os__spec.h
 - remove files/patch-misc_os_spec.h

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-19 11:34:19 UTC
A commit references this bug:

Author: ale
Date: Thu Feb 19 11:34:06 UTC 2015
New revision: 379340
URL: https://svnweb.freebsd.org/changeset/ports/379340

Log:
  Add armv6 as supported arch.

  PR:		197609
  Submitted by:	egypcio@googlemail.com

Changes:
  head/security/cryptlib/Makefile
  head/security/cryptlib/files/patch-misc_os_spec.h