Bug 197768

Summary: multimedia/plexmediaserver-plexpass: update to 0.9.11.12.869
Product: Ports & Packages Reporter: Ralf van der Enden <tremere>
Component: Individual Port(s)Assignee: Mark Felder <feld>
Status: Closed FIXED    
Severity: Affects Many People Flags: bugzilla: maintainer-feedback? (feld)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to update the port to 0.9.11.12.869
none
build log none

Description Ralf van der Enden 2015-02-17 19:41:20 UTC
Created attachment 153116 [details]
patch to update the port to 0.9.11.12.869

Update to latest version.

Also modify the rc.d script so it cleans up remaining 'Plex Plug-in' and 'Plex DLNA Server' instances.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-17 19:41:20 UTC
Auto-assigned to maintainer feld@FreeBSD.org
Comment 2 Ralf van der Enden 2015-02-17 19:41:42 UTC
Created attachment 153117 [details]
build log
Comment 3 Mark Felder freebsd_committer freebsd_triage 2015-02-18 14:59:04 UTC
I'm taking a different approach with the rc script. I've analyzed the child processes and they don't all have the same PPID as the main Plex process, but they have the same PGID. I can do something like this instead which is much cleaner:

plex_stop_precmd()
{
        if [ -r ${pidfile} ]; then
                export _PLEXPID=$(cat ${pidfile})
        fi
}

plex_stop_postcmd()
{
        _PLEX_CHILDREN=$(pgrep -g ${_PLEXPID})
        echo "Cleaning up leftover child processes."
        kill $sig_stop ${_PLEX_CHILDREN}
        wait_for_pids ${_PLEX_CHILDREN}
}
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-18 15:11:35 UTC
A commit references this bug:

Author: feld
Date: Wed Feb 18 15:11:11 UTC 2015
New revision: 379209
URL: https://svnweb.freebsd.org/changeset/ports/379209

Log:
  Update to 0.9.11.12.869
  Teach the rc script to clean up children.

  PR:		197768

Changes:
  head/multimedia/plexmediaserver-plexpass/Makefile
  head/multimedia/plexmediaserver-plexpass/distinfo
  head/multimedia/plexmediaserver-plexpass/files/plexmediaserver_plexpass.in
  head/multimedia/plexmediaserver-plexpass/pkg-plist