Summary: | net/rtpproxy: rc.d script needs improvements | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Euan Thoms <euan> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
Status: | Closed Overcome By Events | ||||||
Severity: | Affects Some People | CC: | robak | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
This patch fails to apply cleanly, can you please send a new one that does? (In reply to Bartek Rutkowski from comment #1) Well, it did when I submitted it. I noticed the port has been modifed since. But the version of rtpproxy has not changed, so just port revision(s). Since I am trying to get a newer version into the tree (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200751), I think I'll just close this PR. My recommended changes are in my updated port (rtpproxy v2.0.0). |
Created attachment 153129 [details] patch diff for the port net/rtpproxy. Taken from path "/usr/ports/net". The BEFORE directive in the rc.d script needs 'kamailo' appended to it. Since openser and ser are no loger in ports tree, they've been replaced by net/kamailio. There needs to be a way to define the control socket for rtpproxy daemon. The below is sufficient: +rtpproxy_ctrl_socket=${rtpproxy_ctrl_socket:-"udp:0.0.0.0:7722"} -command_args="-l ${rtpproxy_laddr} -p /var/run/rtpproxy.pid" +command_args="-u ${rtpproxy_usr}:${rtpproxy_grp} -l ${rtpproxy_laddr} -s ${rtpproxy_ctrl_socket} -p /var/run/rtpproxy.pid" I've included the patch diff for these changes in attachment. I would be happy to take maintainership of this port, since I have a vested interest in kamailio, which has rtpproxy as a dependency. However I am not a qualified ports maintainer yet. I intend to be one soon, in order to submit a working www/sogo port.