Bug 197807

Summary: print/foxitreader: Broken if DOCS option is unchecked
Product: Ports & Packages Reporter: Johannes Jost Meixner <xmj>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: nivit
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Add conditional deploying of the PDF Manual. xmj: maintainer-approval?

Description Johannes Jost Meixner freebsd_committer freebsd_triage 2015-02-18 20:44:15 UTC
Created attachment 153161 [details]
Add conditional deploying of the PDF Manual.

The foxitreader port uses a port option for DOCS to determine wether a PDF should be downloaded, but then unconditionally tries to install said PDF into DOCSDIR.

This fails, lacking the file in DISTDIR.

Patch attached fixes this.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2015-02-18 20:57:00 UTC
*** Bug 197808 has been marked as a duplicate of this bug. ***
Comment 2 Nicola Vitale freebsd_committer freebsd_triage 2015-02-18 21:05:11 UTC
Hi, thanks for reporting that. I just updated the port to 5.1.8, and it no longer installs that file. May I close this PR?
Comment 3 Nicola Vitale freebsd_committer freebsd_triage 2015-02-18 21:14:09 UTC
Ops, I don't know how, but I have read spideroak instead of foxitreader. So I approve that patch. :-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-18 21:19:07 UTC
A commit references this bug:

Author: nivit
Date: Wed Feb 18 21:18:42 UTC 2015
New revision: 379314
URL: https://svnweb.freebsd.org/changeset/ports/379314

Log:
  - Fix installation when DOCS option is off

  PR:	197807
  Submitted by:	xmj

Changes:
  head/print/foxitreader/Makefile
Comment 5 Nicola Vitale freebsd_committer freebsd_triage 2015-02-18 21:22:26 UTC
Committed, thanks for the PR.
Comment 6 Nicola Vitale freebsd_committer freebsd_triage 2015-02-22 23:41:52 UTC
*** Bug 197809 has been marked as a duplicate of this bug. ***