Bug 197816

Summary:	sysutils/pftop: doesn't compile on -CURRENT with GCC (MIPS64)
Product:	Ports & Packages	Reporter:	Daniel Engberg <diizzy>
Component:	Individual Port(s)	Assignee:	Marcelo Araujo <araujo>
Status:	Closed Unable to Reproduce
Severity:	Affects Some People	CC:	lists
Priority:	---	Flags:	bugzilla: maintainer-feedback? (araujo)
Version:	Latest
Hardware:	mips
OS:	Any

Description Daniel Engberg freebsd_committer

2015-02-19 09:25:56 UTC

I haven't been testing this on the MIPS platform for quite some time now but I think the latest bugfix (188826) only worked with CLANG and not GCC (CLANG doesn't work on MIPS/MIPS64 yet).

===>   pftop-0.7_4 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by pftop-0.7_4 for building
===>  Extracting for pftop-0.7_4
=> SHA256 Checksum OK for pftop-0.7.tar.gz.
===>  Patching for pftop-0.7_4
===>  Applying extra patch /usr/ports/sysutils/pftop/files/extra-patch-bpf_dump.c
===>  Applying extra patch /usr/ports/sysutils/pftop/files/extra-patch-sf-gencode.h
===>  Applying extra patch /usr/ports/sysutils/pftop/files/extra-patch-cache.c
===>  Applying extra patch /usr/ports/sysutils/pftop/files/extra-patch-cache.h
===>  Applying extra patch /usr/ports/sysutils/pftop/files/extra-patch-config.h
===>  Applying extra patch /usr/ports/sysutils/pftop/files/extra-patch-pftop.c
===>  Applying extra patch /usr/ports/sysutils/pftop/files/extra-patch-sf-gencode.c
===>  Applying extra patch /usr/ports/sysutils/pftop/files/extra-patch-engine.c
===>  Applying FreeBSD patches for pftop-0.7_4
===>  Configuring for pftop-0.7_4
===>  Building for pftop-0.7_4
--- objwarn ---
Warning: Object directory not changed from original /usr/ports/sysutils/pftop/work/pftop-0.7
--- sf-grammer.c ---
--- sf-scanner.c ---
--- sf-grammer.c ---
yacc -d -o sf-grammer.c sf-grammer.y
--- sf-scanner.c ---
lex  -osf-scanner.c sf-scanner.l
--- pftop.8.gz ---
gzip -cn pftop.8 > pftop.8.gz
--- pftop.o ---
cc -O -pipe -G0  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing -G0   -Wall -DOS_LEVEL=45 -std=gnu89    -c pftop.c
--- cache.o ---
cc -O -pipe -G0  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing -G0   -Wall -DOS_LEVEL=45 -std=gnu89    -c cache.c
--- pftop.o ---
pftop.c: In function 'read_states':
pftop.c:857: warning: pointer targets in passing argument 2 of 'bpf_filter' differ in signedness
pftop.c: In function 'print_rule':
pftop.c:1652: warning: passing argument 2 of 'print_fld_size' makes integer from pointer without a cast
--- engine.o ---
cc -O -pipe -G0  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing -G0   -Wall -DOS_LEVEL=45 -std=gnu89    -c engine.c
--- sf-gencode.o ---
cc -O -pipe -G0  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing -G0   -Wall -DOS_LEVEL=45 -std=gnu89    -c sf-gencode.c
sf-gencode.c: In function 'gen_ifname':
sf-gencode.c:1861: warning: pointer targets in passing argument 3 of 'gen_bcmp' differ in signedness
--- sf-grammer.o ---
cc -O -pipe -G0  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing -G0   -Wall -DOS_LEVEL=45 -std=gnu89    -c sf-grammer.c
--- pcap-nametoaddr.o ---
cc -O -pipe -G0  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing -G0   -Wall -DOS_LEVEL=45 -std=gnu89    -c pcap-nametoaddr.c
--- bpf_optimize.o ---
cc -O -pipe -G0  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing -G0   -Wall -DOS_LEVEL=45 -std=gnu89    -c bpf_optimize.c
--- bpf_filter.o ---
cc -O -pipe -G0  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing -G0   -Wall -DOS_LEVEL=45 -std=gnu89    -c bpf_filter.c
bpf_filter.c: In function 'bpf_filter':
bpf_filter.c:150: error: argument 'pc' doesn't match prototype
/usr/include/pcap/pcap.h:432: error: prototype declaration
bpf_filter.c:150: error: argument 'p' doesn't match prototype
/usr/include/pcap/pcap.h:432: error: prototype declaration
*** [bpf_filter.o] Error code 1

make[1]: stopped in /usr/ports/sysutils/pftop/work/pftop-0.7
1 error

make[1]: stopped in /usr/ports/sysutils/pftop/work/pftop-0.7
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/pftop

FreeBSD 11.0-CURRENT #0 r278472

Best Regards
Daniel

Comment 1 Bugzilla Automation freebsd_committer

2015-02-19 09:25:56 UTC

Auto-assigned to maintainer araujo@FreeBSD.org

Comment 2 Marcelo Araujo freebsd_committer

2015-03-19 03:15:57 UTC

Hi,

Do you have any patch for MIPS?
I don't have any MIPS machine with me.

Comment 3 Oliver Peter 2015-03-19 08:59:57 UTC

Hi guys,

Neither do I have access to a MIPS machine nor am I able to reproduce this on amd64 with gcc{46,47,48}.  Is there still gcc in base for FreeBSD/MIPS?
I cannot even say if this was working before the latest patch.

daniel:
  Which version of pcap are you using (ports/base)?

Cheers
~ollie

Comment 4 Daniel Engberg freebsd_committer

2015-03-19 12:36:58 UTC

Hi,

Unfortunately it's beyond my abilities to fix but I can provide access to a MIPS64 machine if anyone is interested. GCC (the old one in base) is still used as LLVM+CLANG is still somewhat broken on this platform. Building base is still an issue and its being tracked here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197259

Best regards,
Daniel

Comment 5 Daniel Engberg freebsd_committer

2015-03-19 12:39:07 UTC

@ Oliver
I'm using base (I guess), I can have look tomorrow.

Best regards,
Daniel

Comment 6 Oliver Peter 2015-03-19 13:49:48 UTC

(In reply to daniel.engberg.lists from comment #4)
Daniel:  A regular ssh user account for a couple of days should do it.  If you want you can contact me offlist via e-mail.

Comment 7 Marcelo Araujo freebsd_committer

2015-06-12 06:03:00 UTC

Thanks Oliver to handle it, I had a problem with my login and I could not reply.
Guys if you need a help, now I'm more free to take a look too. But I don't have MIPS machine.

Comment 8 Oliver Peter 2016-07-12 10:10:42 UTC

(In reply to daniel.engberg.lists from comment #4)
Hi Daniel,

Is this issue still present?  Can you provide a temporary, unprivileged access to an MIPs64 machine where we can try fixing this?

Cheers
Oliver

Comment 9 Daniel Engberg freebsd_committer

2016-07-12 18:57:36 UTC

Sorry for not replying, I pretty sure I sent a private email but it might have been lost as my previous email provider was a bit dodgy. Unfortunately all my MIPS64 boxes (EdgeRouter Lite) are either decommissioned or migrated to Linux in production so I don't have any available. I'm going to close this ticket due to lack of ability to test and I'm not running FreeBSD on mips64 anymore.