Bug 197823
| Summary: | science/massxpert : logic bug revealed by gcc5 | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Marino <marino> |
| Component: | Individual Port(s) | Assignee: | Veniamin Gvozdikov <vg> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(vg) |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Auto-assigned to maintainer vg@FreeBSD.org vg, can you take a look a this? I checked massexpert update - they haven't if you know how to fix that issues, you are welcome to fix it. I can make the error go away. The question is whether or not the logic will be correct (I haven't actually looked yet) Is this some kind of university student-written software? In any case, a bug report should be filed since I suspect they want gcc to be able to compile it. I'll take a look to try to fix it, but really upstream should care about this since it's a real programming flaw. A commit references this bug: Author: marino Date: Sun Mar 22 00:06:36 UTC 2015 New revision: 381882 URL: https://svnweb.freebsd.org/changeset/ports/381882 Log: science/massxpert: Fix two logical errors (found by gcc5) There were two boolean logic issues found by gcc5 when compiling massxpert. One was comparing boolean output to a negative integer (is always false) and the other applied the "not" operator in the wrong place. Fix provided per request by maintainer. PR: 197823 Changes: head/science/massxpert/Makefile head/science/massxpert/files/patch-lib_cleaveSpec.cpp head/science/massxpert/files/patch-plugins-src_seqToolsPlugin_seqToolsPluginDlg.cpp fixed, hopefully correctly. Can't be worse ... |
Attempting to build massxpert has reveal a logic bug: /wrkdirs/science/massxpert/work/massxpert-3.4.0/lib/cleaveSpec.cpp: In member function 'bool massXpert::CleaveSpec::validate()': /wrkdirs/science/massxpert/work/massxpert-3.4.0/lib/cleaveSpec.cpp:430:17: error: comparison of constant '-1' with boolean expression is always false [-Werror=bool-compare] if (parse() == -1) ^ cc1plus: all warnings being treated as errors I could try fixing it but I think it's better if the maintainer takes a look first (and perhaps contact upstream)