Bug 197868

Summary: Fix devel/py-gevent build with clang 3.6.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Many People Flags: bugzilla: maintainer-feedback? (sunpoet)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 197395    
Attachments:
Description Flags
Fix positioning of _Noreturn attribute for py-gevent's copy of libev none

Description Dimitry Andric freebsd_committer freebsd_triage 2015-02-20 22:38:03 UTC 
Created attachment 153252 [details]
Fix positioning of _Noreturn attribute for py-gevent's copy of libev

During the exp-run in bug 197395, it was found that devel/py-gevent gives errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-11_23h04m51s/logs/errors/py27-gevent-1.0.1.log

This is because clang 3.6.0 defaults to C11, and libev puts its ecb_noreturn in the wrong place, at the end of a function declaration.

The placement was fixed by upstream here:

http://cvs.schmorp.de/libev/ev.c?r1=1.473&r2=1.474

but this also has a lot of other unneeded changes.  So I propose the following minimal fix, which changes just two lines.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-20 22:38:03 UTC 
Auto-assigned to maintainer sunpoet@FreeBSD.org
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-02-21 15:11:29 UTC 
A commit references this bug:

Author: sunpoet
Date: Sat Feb 21 15:11:22 UTC 2015
New revision: 379519
URL: https://svnweb.freebsd.org/changeset/ports/379519

Log:
  - Fix build with Clang 3.6.0

  PR:		197868
  Submitted by:	dim

Changes:
  head/devel/py-gevent/files/
  head/devel/py-gevent/files/patch-libev-ev.c
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-02-21 15:13:11 UTC 
Committed. Thanks!