Summary: | [patch] update devel/p5-Module-Build to 0.4211 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Adam Weinberger <adamw> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-perl (Nobody) <perl> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | adamw, az | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(perl) adamw: exp-run? |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Adam Weinberger
2015-02-21 16:49:40 UTC
Auto-assigned to maintainer perl@FreeBSD.org Assigning to portmgr for consideration for exp-run. IMHO, I don't think you need to run exp-run, you can look history and only few time people did such thing for this module. As test just take random 10 ports which are consumers of Module::Build and try to build them with a new version. Also don't forget what you need to modify Mk/Uses/perl5.mk to use latest version of Module::Build. No, you *do not* *need* to touch Mk/Uses/perl5.mk to use the latest version. You *only* do that if you have *compelling* evidence that ports need to have the latest version right now. 99.9% of the time, you do *not* touch Mk/Uses/perl5.mk because no ports *needs* the latest version. (In reply to Mathieu Arnold from comment #4) Yes, Makefile contain comment about this, but as i'm already mentioned Perl toolchain must be always latest versions. I'm talking about Module::Build and ExtUtils::MakeMaker. For example nobody cares why we are using M::B from ports while it also in core and mixing usage of EU::MM instead of always use latest form ports. Don't get me wrong, but it's hard to use your rule of compelling evidence here. If we building Foo-Y with toolchain version X we must be sure what user using same toolchain version X to build Foo-Y. For me this sound reasonable :-) That was the main reason that I thought I'd ask about an exp-run, to be positive that the minimum required version in Uses/perl5.mk didn't need to be bumped. I haven't found any problems using the new version so far. If portmgr and the rest of perl@ are comfortable with it I'm happy to commit it, but as this is new territory for me I figured I'd ask the people who've dealt with it before. (In reply to Adam Weinberger from comment #6) An exp-run won't catch if the minimum required version in Uses/perl5.mk need to be bumped or not. From an exp-run point of view, it's ok. I let perl@ folks decide about version bumps in perl5.mk and the error about newer version of inc::latest since I have no clue about this. A commit references this bug: Author: adamw Date: Wed Feb 25 19:39:47 UTC 2015 New revision: 379959 URL: https://svnweb.freebsd.org/changeset/ports/379959 Log: Update to 0.4211. Changes: https://metacpan.org/changes/distribution/Module-Build This update brings in a dependency on p5-CPAN-Meta, which itself has a number of dependencies. PR: 197880 Changes: head/devel/p5-Module-Build/Makefile head/devel/p5-Module-Build/distinfo head/devel/p5-Module-Build/pkg-plist Okay. I'm committing this. I've been building everything with it for a couple days now and nothing's caught fire. |