Bug 197920

Summary: [patch] shells/pdksh : fails to build on gcc5 due to cpp, here is fix
Product: Ports & Packages Reporter: John Marino <marino>
Component: Individual Port(s)Assignee: Rodrigo Osorio <rodrigo>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (rodrigo)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
pdksh patch to use tradcpp in siglist.sh script
none
Better fix for gcc-5 none

Description John Marino freebsd_committer freebsd_triage 2015-02-22 14:53:06 UTC
Created attachment 153315 [details]
pdksh patch to use tradcpp in siglist.sh script

The pdksh port will fail to build with gcc5 because of a behavioral change in the cpp program that it comes with.  However, the default replacement, tradcpp, will cause the configure to fail.  The fix is not pretty, it is to use GCC cpp everything except the siglist.sh script.

The error is as follows:
--- siglist.out ---
./siglist.sh "cpp  -DHAVE_CONFIG_H -I. -I." < ./siglist.in > tmpsiglist.out
--- siglist.out ---
*** [siglist.out] Error code 1

The attached patch will force siglist.sh to use tradcpp instead which allows for the program to successfully build on gcc5.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-22 14:53:06 UTC
Auto-assigned to maintainer rodrigo@FreeBSD.org
Comment 2 John Marino freebsd_committer freebsd_triage 2015-03-01 19:03:32 UTC
hold off on this, tradcpp has been giving FreeBSD 11 fits (see libgpg-error mess)
Comment 3 John Marino freebsd_committer freebsd_triage 2015-04-02 07:50:47 UTC
Created attachment 155115 [details]
Better fix for gcc-5

This is a simpler fix and doesn't require new dependencies.

Please continue your evaluation of this PR.
Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-04-03 23:51:02 UTC
A commit references this bug:

Author: rodrigo
Date: Fri Apr  3 23:50:16 UTC 2015
New revision: 383182
URL: https://svnweb.freebsd.org/changeset/ports/383182

Log:
  Fix build with gcc5

  PR:		197920
  Submitted by:	marino

Changes:
  head/shells/pdksh/Makefile
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2015-04-03 23:51:35 UTC
Committed, sorry for the delay.