Summary: | devel/libosmo*: simplify and misc fixes | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
Component: | Individual Port(s) | Assignee: | Jan Beich <jbeich> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | koue | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Jan Beich
![]() Endian stuff is tricky. A portable code would have to account for all the places endian.h can be found and all the underscores/prefixes various implementations have. It's way easier to just include endian.h in the few places that have #if __BYTE_ORDER == __LITTLE_ENDIAN and sed(1) everything into shape that builds on BSDs. Ironically, the above conditional would compile without warnings even when the macros are undefined. They're implicitly converted to 0 and thus the comparison is always true. I'm agree with ports changes. A commit references this bug: Author: jbeich Date: Tue Feb 24 08:00:59 UTC 2015 New revision: 379763 URL: https://svnweb.freebsd.org/changeset/ports/379763 Log: - Unbreak on DragonFly - Unbreak on big-endian archs [1] - Unbreak and rename DOCS option [2] - Convert to USES=autoreconf - Convert to USES=pathfix - Convert to INSTALL_TARGET=install-strip - Convert to PORTDOCS - Fix whitespace - Bump PORTREVISION for [1], [2] Differential Revision: https://reviews.freebsd.org/D1947 PR: 197948 Reviewed by: marino, pi Approved by: Nikola Kolev <koue@chaosophia.net> (maintainer) Changes: head/devel/libosmo-abis/Makefile head/devel/libosmo-sccp/Makefile head/devel/libosmo-sccp/files/ head/devel/libosmocore/Makefile head/devel/libosmocore/files/patch-Makefile.am A commit references this bug: Author: jbeich Date: Tue Feb 24 08:03:08 UTC 2015 New revision: 379764 URL: https://svnweb.freebsd.org/changeset/ports/379764 Log: Register CONFLICTS between libmtp and libosmo-sccp Differential Revision: https://reviews.freebsd.org/D1947 PR: 197948 Reviewed by: marino, pi Approved by: Nikola Kolev <koue@chaosophia.net> (maintainer) Changes: head/devel/libosmo-sccp/Makefile head/multimedia/libmtp/Makefile |