Bug 198011

Summary: Fix devel/rcs build with clang 3.6.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Niclas Zeising <zeising>
Status: Closed FIXED    
Severity: Affects Many People CC: kwm
Priority: --- Flags: bugzilla: maintainer-feedback? (zeising)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 197395    
Attachments:
Description Flags
Fix positioning of _Noreturn attribute for rcs none

Description Dimitry Andric freebsd_committer freebsd_triage 2015-02-24 21:04:15 UTC 

    


    


      



        
          Comment 1
        

        
          Bugzilla Automation

        

        
            freebsd_committer
            freebsd_triage
        

        
          2015-02-24 21:04:15 UTC
        

      






Auto-assigned to maintainer zeising@FreeBSD.org

    


    


      



        
          Comment 2
        

        
          Dimitry Andric

        

        
            freebsd_committer
            freebsd_triage
        

        
          2015-02-24 21:05:49 UTC
        

      






Created attachment 153472 [details]
Fix positioning of _Noreturn attribute for rcs

During the exp-run in bug 197395, it was found that devel/rcs gives errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-11_23h04m51s/logs/errors/rcs-5.9.2.log

I propose the following fix, which puts the 'exiting' macro (which is an alias for the _Noreturn keyword) at the start of the function declarations.

    


    


      



        
          Comment 3
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2015-03-10 09:53:03 UTC
        

      






A commit references this bug:

Author: kwm
Date: Tue Mar 10 09:53:01 UTC 2015
New revision: 380905
URL: https://svnweb.freebsd.org/changeset/ports/380905

Log:
  Fix build with clang 3.6.0 by moving the 'exiting' macro (which is an alias
  for the _Noreturn keyword) to the start of the function declaration.

  PR:		198011
  Submitted by:	dim@ (reported by clang 3.6 exp-run)
  Approved by:	maintainer (via IRC)

Changes:
  head/devel/rcs/files/patch-src__b-complain.h
  head/devel/rcs/files/patch-src__b-fb.h
  head/devel/rcs/files/patch-src__base.h