Bug 198042
| Summary: | [MAINTAINER] security/maia: Update to 1.0.4, Lots of PERL fixes | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | ek | ||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | perl, pi | ||||||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
I submitted the same update a little over a week ago using 'send-pr' but I understand that 'send-pr' is no longer working. So, I'm sorry if this is a duplicate. The staging does not work because the chgrp happens before the group is created: install -m 640 /usr/local/home/pi/myp/security/maia/work/maia-1.0.4/maia.conf.dist /usr/local/home/pi/myp/security/maia/work/stage/usr/local/etc/maia/maia.conf.dist /usr/bin/chgrp vscan /usr/local/home/pi/myp/security/maia/work/stage/usr/local/etc/maia/maia* chgrp: vscan: illegal group name Can you check this issue ? (In reply to Kurt Jaeger from comment #2) You're partially right, the chgrp fails here because as root, the group does not exist, but it's more because it can't work, staging must work as a regular user, and you can't chgrp then. Ah. This makes sense. I'm not sure how I missed this before... Any suggestions on best practice to fix it? I'd like to keep the permissions the same. Perhaps a chmod/chown instead? There are several places in the porters handbook that hint on how this is done using the pkg-plist file: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#plist-keywords which refers to this example: @sample(games,games,640) etc/config.sample and 7.6.7.6. @owner user which sets the default ownership for all subsequent files to user. Use without an argument to set back to default ownership (root). (similar for @group etc). Gotcha'. I'm actually already using this technique throughout my pkg-plist file. Perhaps that's how I'd missed it before (maybe I removed it for some reason..?) I'll fix this and re-submit a new patch after I test the staging process. Created attachment 153629 [details]
New patch for maia-1.0.4.
Fixed ${CHGRP} issue in Makefile and added missing files in pkg-plist.
Thanks for your help, guys. Everything appears to install correctly now. When I try to build it, with DEVELOPER=yes in /etc/make.conf, the pkg-plist gives many errors. It does not build in poudriere. I build it with make check-plist build logs: http://people.freebsd.org/~pi/logs/security__maia* Interesting... Thanks for the info Kurt. I'll take a look at this and get it all fixed. Created attachment 154949 [details]
Latest diff.
Latest 1.0.4 patch.
Created attachment 154950 [details]
Poudriere log.
Poudriere success log.
Hi Guys, Looks like I've finally got this all sorted out (sorry it took so long). I've attached the patch for the port as well as the successful Poudriere log. Everything seems to be working as expected. If you have any other issues, please let me know. testing@work A commit references this bug: Author: pi Date: Sun Mar 29 08:41:55 UTC 2015 New revision: 382571 URL: https://svnweb.freebsd.org/changeset/ports/382571 Log: security/maia: 1.0.3 -> 1.0.4 TODO: find a suitable changelog PR: 198042 Submitted by: ek@purplehat.org (maintainer) Changes: head/security/maia/Makefile head/security/maia/distinfo head/security/maia/files/pkg-message.in head/security/maia/pkg-plist Committed, thanks for the hard work! If possible, can you provide a ChangeLog -- what has changed since the last version ? |
Created attachment 153533 [details] Diff for security/maia port.