Bug 198113

Summary: Fix security/pam_ocra build with clang 3.6.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Bartek Rutkowski <robak>
Status: Closed FIXED    
Severity: Affects Many People CC: robak, sg2342
Priority: --- Flags: bugzilla: maintainer-feedback? (sg2342)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 197395    
Attachments:
Description Flags
Constify two local variables to avoid -Wcast-qual warnings
none
update security/pam_ocra to 1.2 none

Description Dimitry Andric freebsd_committer freebsd_triage 2015-03-01 00:05:58 UTC 
Created attachment 153633 [details]
Constify two local variables to avoid -Wcast-qual warnings

During the exp-run in bug 197395, it was found that security/pam_ocra gives errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-27_12h37m16s/logs/errors/pam_ocra-1.1.log

These errors are -Werror warnings about dropping const qualifiers.  This is easy to fix, as in the attached patch, which adds two const qualifiers to local variables.  No functional change.
Comment 1 Stefan Grundmann 2015-03-04 04:12:21 UTC 
Created attachment 153759 [details]
update security/pam_ocra to 1.2

I have included the proposed fix in the upstream git repo.
attached patch updates the port to 1.2
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-03-05 12:44:20 UTC 
A commit references this bug:

Author: robak
Date: Thu Mar  5 12:43:56 UTC 2015
New revision: 380487
URL: https://svnweb.freebsd.org/changeset/ports/380487

Log:
  security/pam_ocra: update 1.1 -> 1.2

  - Include upstream accepted Clang 3.6.0 fixes by Dimitry Andric <dim@FreeBSD.org>

  PR:		198113
  Submitted by:	Stefan Grundmann <sg2342@googlemail.com>

Changes:
  head/security/pam_ocra/Makefile
  head/security/pam_ocra/distinfo
Comment 3 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-05 12:44:50 UTC 
Committed, thanks for your work guys!