Bug 198116
| Summary: | [patch] graphics/gdal : don't substitute -lpthread with -pthread anymore | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Marino <marino> | ||||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | portmgr, thierry, tijl | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198794 | ||||||||
| Attachments: |
|
||||||||
Remark: ${PTHREAD_LIBS} is still defined in ports/Mk/bsd.port.mk as:
PTHREAD_LIBS?= -pthread
I've never seen a case where it would break the build, but in that case, it should be modified too.
good catch! I'll CC portmgr. Portmgr, does removing -pthread from bsd.port.mk require a second PR? I'll also CC tijl because if I recall correctly, he's the resident expert on this topic. FreeBSD used to have two libc, one without threading (libc.so) and one with (libc_r.so). With -pthread the compiler would link with libc_r instead of libc. Nowadays there's only one libc and -pthread tells the compiler to link with libpthread, exactly like -lpthread does. Both work and patches that change -lpthread into -pthread or vice versa are redundant. Created attachment 153641 [details]
updated patch
The first patch missed one -pthread to change
sunpoet -- this PR timed out. I am authorized to commit the patch at any time. I'll leave it for a couple more days though. A commit references this bug: Author: sunpoet Date: Sun Mar 22 20:11:18 UTC 2015 New revision: 381955 URL: https://svnweb.freebsd.org/changeset/ports/381955 Log: - Use -lpthread instead of -pthread PR: 198116 Submitted by: marino Changes: head/graphics/gdal/Makefile Committed. Thanks! |
Created attachment 153637 [details] removal of -pthread substitution There is no reason to use -pthread anymore. At best there is no difference and at worst it can break the build in some cases. The simple attached patch should be applied to gdal. I don't see a reason for a revbump though. I didn't thoroughly test this on all releases though.