Bug 198202

Summary:

Fix emulators/open-vm-tools build with clang 3.6.0

Product:

Ports & Packages

Reporter:

Dimitry Andric <dim>

Component:

Individual Port(s)

Assignee:

Steve Wills <swills>

Status:

Closed FIXED

Severity:

Affects Many People

Flags:

swills: maintainer-feedback+

Priority:

---

Version:

Latest

Hardware:

Any

OS:

Any

Bug Depends on:

Bug Blocks:

197395

Attachments:

Description	Flags
Add unused attribute to hand-rolled static_assert constructs	none

Description Dimitry Andric freebsd_committer

2015-03-02 20:07:19 UTC

Created attachment 153689 [details]
Add unused attribute to hand-rolled static_assert constructs

During the exp-run in bug 197395, it was found that emulators/open-vm-tools and emulators/open-vm-tools-nox11 give errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-27_12h37m16s/logs/errors/open-vm-tools-1280544_10,1.log

This is because (part of) the code is compiled with -Werror, and unused local typedefs, which are used for compile-time assertions, are now warned about.  The attached patch fixes this by adding an unused attribute.

Comment 1 Steve Wills freebsd_committer

2015-03-02 21:13:42 UTC

Approved

Comment 2 commit-hook freebsd_committer

2015-03-02 21:36:58 UTC

A commit references this bug:

Author: dim
Date: Mon Mar  2 21:36:52 UTC 2015
New revision: 380297
URL: https://svnweb.freebsd.org/changeset/ports/380297

Log:
  Fix -Werror warnings from clang 3.6.0 and higher about unused local
  typedefs, which are used for hand-implementing compile-time assertions,
  by adding an __unused__ attribute.

  Approved by:	maintainer (swills)
  PR:		198202

Changes:
  head/emulators/open-vm-tools/files/patch-lib__include__vm_assert.h
  head/emulators/open-vm-tools/files/patch-lib__include__vm_atomic.h

Comment 3 Dimitry Andric freebsd_committer

2015-03-02 21:39:03 UTC

Fixed by r380297.