Bug 198263
| Summary: | security/fakeident: move source to files, use rc structure | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jason Helfman <jgh> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | dean, jgh, riggs, robak | ||||||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||||||
| Version: | Latest | Flags: | riggs:
maintainer-feedback+
|
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
@jgh, this patch no longer applies, can you submit a new one? Created attachment 162940 [details]
Updated patch, and added a pkg-message.
There is no previous version of fakeidentd.in in the tree, so it gets skipped during patching. Can you re-submit against an up-to-date ports tree? Created attachment 164903 [details]
patch
Attached is the patch. There was no update based on updating my svn checkout. I suspect you will have the same issue.
Are you using svn patch to apply the differential?
-jgh
(In reply to Jason Helfman from comment #4) Yes, I do use svn patch. This happens... > svn patch ~/patch.txt U Makefile D distinfo D files/fakeident.sh D files Skipped missing target: 'files/fakeidentd.in' A files A files/identd.c A pkg-message Summary of conflicts: Skipped paths: 1 ... and is totally expected since there is no files/fakeidentd.in: https://svnweb.freebsd.org/ports/head/security/fakeident/files/ I suspect there is something wrong with your local checkout. Also the patch should not delete the entire files/ dir and recreate it again. Created attachment 164907 [details]
patch fixed
it did seem to be a corrupted checkout on deeper investigation.
this should do it.
-jgh
New patch does not change function or intention of already maintainer-approved patch. A commit references this bug: Author: riggs Date: Thu Dec 31 19:01:06 UTC 2015 New revision: 404959 URL: https://svnweb.freebsd.org/changeset/ports/404959 Log: Include source file in the ports tree; use rc script - The original distfile URL seems to be quite unreliable. The only distfile (a single .c file) is small and hence included in the ports tree. - Use a proper rc startup script. PR: 198263 Submitted by: jgh Approved by: dean@odyssey.apana.org.au Changes: head/security/fakeident/Makefile head/security/fakeident/distinfo head/security/fakeident/files/fakeident.sh head/security/fakeident/files/fakeidentd.in head/security/fakeident/files/identd.c head/security/fakeident/pkg-message Thanks for checking and preparing the new patch! (In reply to Thomas Zander from comment #9) Your welcome, and thanks for putting this through! -jgh |
Created attachment 153754 [details] patch I've moved the source for fakeident into the files directory, as I've found the distfile to not be that reliable. I also doubt the software will ever be actually updated, and since it is so small I didn't see any harm in bringing it into the files directory. I've stripped the binary that is installed, and moved the service to the rc structure. This way it can be properly tracked, and enabled/disabled even at boot time. Please let me know your thoughts! Thanks :) Jason