Bug 198312

Summary: sysutils/lsof: No longer builds after head/r279433
Product: Ports & Packages Reporter: Tomoaki AOKI <junchoon>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Some People CC: ler, vanilla
Priority: --- Keywords: easy, patch
Version: LatestFlags: ler: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Build error log.
none
Update to lsof 4.89D to fix this issue koobs: maintainer-approval+

Description Tomoaki AOKI 2015-03-05 13:15:31 UTC 
Created attachment 153833 [details]
Build error log.

After upgrading head (amd64) from r279417 to r279579, sysutils/lsof no longer builds.

Looking into build log (attached) and commit messages, it seems that r279433 broke build of sysutils/lsof.
(Not actually bi-sected)

Fix:
 Not known. But maybe renaming asprintf() and vasprintf() in
 sys/sys/systm.h and its consumers to avoid conflicts would help from
 base side.


Comment from committer of r279433 (Ryan Stone):

 Would:

 #undef __BSD_VISIBLE
 #include <stdio.h>
 #define __BSD_VISIBLE 1


 Work in lsof?

  https://lists.freebsd.org/pipermail/freebsd-current/2015-March/054940.html
Comment 1 Larry Rosenman freebsd_committer freebsd_triage 2015-03-05 14:02:10 UTC 
I've sent a note to Vic Abell (lsof(1) author) and am awaiting his reply.

I can reproduce this on my 11-CURRENT box.
Comment 2 Larry Rosenman freebsd_committer freebsd_triage 2015-03-05 20:59:23 UTC 
Created attachment 153866 [details]
Update to lsof 4.89D to fix this issue
Comment 3 Larry Rosenman freebsd_committer freebsd_triage 2015-03-05 20:59:47 UTC 
Can a committer commit the attached patch?
Comment 4 Tomoaki AOKI 2015-03-07 03:30:50 UTC 
(In reply to Larry Rosenman from comment #2)
Looks OK for me, too. Thanks!
Looking forward to be committed.
Comment 5 Larry Rosenman freebsd_committer freebsd_triage 2015-03-07 15:40:35 UTC 
I got pkg-fallout messages about this as well. 

Can a committer commit these soon?
Comment 6 Vanilla I. Shu freebsd_committer freebsd_triage 2015-03-07 16:32:01 UTC 
Committed, thanks.
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-03-07 16:32:21 UTC 
A commit references this bug:

Author: vanilla
Date: Sat Mar  7 16:31:55 UTC 2015
New revision: 380705
URL: https://svnweb.freebsd.org/changeset/ports/380705

Log:
  Upgrade to 4.89D

  PR:		198312
  Submitted by:	junchoon@dec.sakura.ne.jp
  Approved by:	maintainer

Changes:
  head/sysutils/lsof/Makefile
  head/sysutils/lsof/distinfo