Bug 198329

Summary: graphics/graphviz: unbreak RUBY option
Product: Ports & Packages Reporter: Mikhail Teterin <mi>
Component: Individual Port(s)Assignee: Dirk Meyer <dinoex>
Status: Closed FIXED    
Severity: Affects Only Me Flags: koobs: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Remove BROKEN-declaration in case of RUBY-option
none
Remove BROKEN-declaration, add RUBY-knobs to configure's environment koobs: maintainer-approval-

Description Mikhail Teterin freebsd_committer freebsd_triage 2015-03-05 19:50:54 UTC
Created attachment 153860 [details]
Remove BROKEN-declaration in case of RUBY-option

With our energetic portmgr team, lang/ruby19 is not even available from the ports-tree any longer, but graphviz still considers itself BROKEN, if the RUBY option is selected by the user.

The BROKEN-logic should always have considered ${RUBY_VER} -- because the breakage, it seems, only existed in ruby-1.9.pc. But these days, when 1.9 is not even available at all, the brokenness check should be simply removed.
Comment 1 Mikhail Teterin freebsd_committer freebsd_triage 2015-03-05 22:28:26 UTC
Created attachment 153871 [details]
Remove BROKEN-declaration, add RUBY-knobs to configure's environment

This version also adds RUBY_CFLAGS and RUBY_LIBS to configure's environment --  otherwise configure will try to use pkgconfig to find "ruby" and fail because we install the package as ruby-X.Y instead of simply ruby.
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2015-03-08 10:05:54 UTC
patch not approved
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-03-08 10:08:15 UTC
A commit references this bug:

Author: dinoex
Date: Sun Mar  8 10:07:36 UTC 2015
New revision: 380755
URL: https://svnweb.freebsd.org/changeset/ports/380755

Log:
  - fix option RUBY to build with ruby 2.1
  PR:		198329

Changes:
  head/graphics/graphviz/Makefile