| Summary: | [PATCH] sysutils/condor: Replace deprecated des_ and fix LibreSSL build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bernard Spil <brnrd> | ||||||
| Component: | Individual Port(s) | Assignee: | Rene Ladan <rene> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | jwb, rene | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(jwb) |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 153930 [details]
Poudriere build log sysutils/condor
Patch approved. Feedback from upstream
Hi,
The HTCondor code contains a number of deprecated des_ methods and types
that have been deprecated since OpenSSL 0.9.7. The attached patches
contain replacements with the respective DES_ methods and types. The
des_old.h has been removed from LibreSSL and will be removed from
OpenSSL with 1.1.0.
This was discovered during a build of all FreeBSD ports with LibreSSL by
PC-BSD, see https://wiki.freebsd.org/LibreSSL.
Hi Bernard,
Thank you for your effort and attached patch. I will be reviewing it and
committing it to our repository if all seems well.
Would you be willing to sign an HTCondor "Contributor License Agreement"? It
basically states that you own the code but you are giving us a license to use
it in perpetuity. You can see it here:
http://research.cs.wisc.edu/htcondor/licenses/CLA-PUBLIC.pdf
If so, please send me a PDF of the signed form. You'll also be included in
the list of contributers, unless you would prefer otherwise.
Once again, thanks for the patch!
Cheers,
-zach
A commit references this bug: Author: rene Date: Tue Apr 7 18:04:57 UTC 2015 New revision: 383528 URL: https://svnweb.freebsd.org/changeset/ports/383528 Log: sysutils/condor: replace deprecated des_ and fix LibreSSL build The default build is unaffected. PR: 198370 Submitted by: Bernard Spil Approved by: maintainer (jwbacon@tds.net) Changes: head/sysutils/condor/files/patch-src__condor_includes__condor_crypt_3des.h head/sysutils/condor/files/patch-src__condor_io__condor_crypt_3des.cpp |
Created attachment 153929 [details] svn diff for sysutils/condor sysutils/condor uses deprecated des_ methods and types that were marked deprecated by OpenSSL 0.9.7 and will be removed in OpenSSL 1.1.0 . This patch replaces the des_ methods and types with their new DES_ counterparts. I've mailed the upstream project with the patches.