Bug 198411
| Summary: | Restrict "ports framework" and "package infrastructure" components from the Ports & Packages product to committers only. | ||
|---|---|---|---|
| Product: | Services | Reporter: | Mathieu Arnold <mat> |
| Component: | Bug Tracker | Assignee: | Bugmeister <bugmeister> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | gonzo, koobs, linimon, mmokhi, swills |
| Priority: | --- | Keywords: | feature, needs-patch |
| Version: | unspecified | ||
| Hardware: | Any | ||
| OS: | Any | ||
| See Also: |
https://bugzilla.mozilla.org/show_bug.cgi?id=317051 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228504 |
||
|
Description
Mathieu Arnold
2015-03-08 09:42:07 UTC
ping ? It's not that it's a big burden, but portmgr still receives one or two wrongly assigned PR each day, if this is possible, it'd be great :-) I'd opt for bumping the upstream issue (referenced in this bug) to ensure it gets committed there and is available in future versions. There is a patch in the upstream issue (of unknown quality) that *may* be able to patched into out local instance, though I'm not entirely comfortable with patching given the low impact. Having said that, I will note that it is desirable to mitigate misclassification where we can do so without adding overhead. For reference, this can/could be done in the template Is this ever going to be fixed ? it is really annoying. @Mokhi Could you look at confirming whether its possible and what changes are required to setting a particular Component as the default (selected) for a Product via templates? ping (In reply to Kubilay Kocak from comment #5) Hi. Sorry for late in my response. I've checked requirement changes needed for that feature in Bugzilla template. It's not so big, but a little fundamental. Can we keep them as local patches for our project or Bugzilla will accept it? As more detailed explanations, we need to change these modules and templates to add a default component: 'Bugzilla/Bug.pm' 'Bugzilla/Product.pm' 'Bugzilla/DB/Schema.pm' 'editproducts.cgi' 'template/en/default/admin/products/edit.html.tmpl' 'template/en/default/bug/create/create.html.tmpl' 'template/en/default/global/select-menu.html.tmpl' 'template/en/default/admin/products/edit-common.html.tmpl' And to keep things backward compatible, we have to change this too: 'Bugzilla/Install/DB.pm' If you're okay with it, I can happily work on it :) If this cannot be done, maybe the "ports framework" and "package infrastructure" could be restricted to committers. (In reply to Mathieu Arnold from comment #9) Well I listed the files/parts which changes are needed to be done on them in order to make default components for parts. If thoughts (by bugmeisters) are done and decisions are made, as I said before I'd be happy to work on it. Though I'm not a committer, but it wouldn't be problem IMO, cause I can do works and publish a patch and committers can review and merge it :) ping ? It would really be great that this goes forward. Having thought about it a bit more, I think if the "ports framework" and "package infrastructure" components were restricted to committers only. Ping. ping. (In reply to Mathieu Arnold from comment #13) Still working on it 😁😅 Sorry for the delay, my Working-Queue is a bit overflowed these days. Hopefully I'll submit the patch on Bugzilla community's issue tracker, and link that PR here too 🙏 ping ping. (In reply to Mathieu Arnold from comment #16) I customized "select product" template and added default category for 'Ports & Packages' product. Could you check if opening new bug via https://bugs.freebsd.org/bugzilla/enter_bug.cgi selects Individual Port category by default? Thank you It does, but I don't have a non-committer account to check that the "ports framework" and "package infrastructure" are not available when you are not a committer. (In reply to Mathieu Arnold from comment #18) There is no easy way to limit components to user group and upstream is not going to implement it AFAIK. All access rights work at product level. So if selecting default component on new bug screen is not enough we have several options: - Move frameworks/infrastructure categories to separate product with write access available for committers group only - Create custom template with hardcoded logic that hides these two categories using templatetoolkit IF directives or javascript - Add ALL CAPS warning to categories help texts use "Individual Ports" category unless you're a committer or know what you're doing. I suggest we monitor number of mis-categorized PRs with current fix, if it's not acceptable we apply option (3) if number does not go down - resort to first two options. Mmm, ok, let's see how this goes. So, nothing has changed. We still get badly assigned PR on a daily basis. ping (In reply to Mathieu Arnold from comment #22) I'm going to try to hide these categories using template language. I limited these two categories to committer using extension and template modification. Please test and let me know if fix works for you. Once required functionality is confirmed - I'll commit patch Well, I still have access to those fields, but I do not have a non committer account, so I cannot really test that case. I tested this functionality as committer and non-committer: works as intended. Fix committed as https://github.com/gonzoua/bugzilla/commit/ff60c1c4eb37781ea04f4e7b446c5ff3d8c4747e |