Bug 198560

Summary: [PATCH] x11-wm/xfce4-session: appropriately disable verbose log
Product: Ports & Packages Reporter: lichray
Component: Individual Port(s)Assignee: Olivier Duchateau <olivierd>
Status: Closed FIXED    
Severity: Affects Only Me CC: olivierd
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (xfce)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
under files/ none

Description lichray 2015-03-13 08:23:20 UTC 
Created attachment 154261 [details]
under files/

The upstream change unconditionally logs:

  https://github.com/EricKoegel/xfce4-session/commit/970249c095f31eaeb8f7bb4bb5f835c669c37e57

I read it as a mistake.
Comment 1 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-13 17:36:59 UTC 
I close this PR. I think changes need to be reported upstream.
Comment 2 lichray 2015-03-13 17:40:05 UTC 
(In reply to Olivier Duchateau from comment #1)

It is a good thing to report upstream, but your users need this immediately.
Comment 3 lichray 2015-03-28 17:37:21 UTC 
(In reply to Olivier Duchateau from comment #1)

FYI, already merged in upstream:

  http://git.xfce.org/xfce/xfce4-session/commit/?id=26f9ae8df629f02af0773df2ed82db6b85c5b556
Comment 4 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-28 20:10:58 UTC 
Re-open, approved by upstream.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-03-28 20:28:15 UTC 
A commit references this bug:

Author: olivierd
Date: Sat Mar 28 20:28:10 UTC 2015
New revision: 382552
URL: https://svnweb.freebsd.org/changeset/ports/382552

Log:
  - Add patch, to make verbose logging conditional
  - Bump PORTREVISION

  PR:		198560
  Submitted by:	Zhihao Yuan <lichray@gmail.com>

Changes:
  head/x11-wm/xfce4-session/Makefile
  head/x11-wm/xfce4-session/files/patch-xfce4-session_xfsm-global.h
Comment 6 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-28 20:29:13 UTC 
Committed, thanks!