Bug 198704
| Summary: | [NEW PORT] www/py-collective.easytemplate | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Michelle Sullivan <michelle> | ||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Ruslan Makhmatkhanov <rm> | ||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||
| Severity: | Affects Only Me | CC: | rm | ||||||||||||||||||
| Priority: | --- | Keywords: | needs-patch, needs-qa | ||||||||||||||||||
| Version: | Latest | ||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||
| Bug Depends on: | 199946 | ||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
Original attachment only contains 4 lines, please attach a complete shar archive and obsolete attachment 154512 [details]
As per IRC, please also include attachments for QA:
* portlint -AC
* poudriere testport or bulk -t output
Created attachment 154514 [details]
Shar of new port.
(Updated attachment after incorrect Shar creation)
Created attachment 154515 [details]
Shar of new port. (after portlint -AC corrections)
ports/www/py-plone.addon.collective.easytemplate # portlint -AC WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX. WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 2 warnings found. ports/www/py-plone.addon.collective.easytemplate # * Remove py- prefix from PORTNAME * Match PORTNAME to upstream PyPi name * DISTNAME override shouldn't be necessary with the former done * Add LICENSE_FILE if one exists in WRKSRC * COMMENT should match upstream (pypi) shortname. ie: * Sort USE_PYTHON values alphabetically Dynamic HTML generation and scripting of pages, content rules, portlets and emails or maybe a shorter: Dynamic HTML generation and scripting * If 'plone' is *required* in the PKGNAMEPREFIX, append it there (Ruslan?) Created attachment 154516 [details]
New Shar.
Ok after all the discussion (thanks koobs)
removed the 'plone' (waiting on rm@ for final comment on that)
removed the distname
removed the py- (because I'm a f**kwit that didn't read properly)
changed the location/portdir to match the new name:
www/py-collective.easytemplate
root@colossus:/Storage/source/ports/www/py-collective.easytemplate # portlint -AC looks fine. root@colossus:/Storage/source/ports/www/py-collective.easytemplate # ====>> [01] Starting build of www/py-collective.easytemplate ====>> [01] Status for build www/py-collective.easytemplate: check-sanity ====>> [01] Status for build www/py-collective.easytemplate: pkg-depends ====>> [01] Status for build www/py-collective.easytemplate: fetch-depends ====>> [01] Status for build www/py-collective.easytemplate: fetch ====>> [01] Status for build www/py-collective.easytemplate: checksum ====>> [01] Status for build www/py-collective.easytemplate: distfiles ====>> [01] Status for build www/py-collective.easytemplate: extract-depends ====>> [01] Status for build www/py-collective.easytemplate: extract ====>> [01] Status for build www/py-collective.easytemplate: patch-depends ====>> [01] Status for build www/py-collective.easytemplate: patch ====>> [01] Status for build www/py-collective.easytemplate: build-depends ====>> [01] Status for build www/py-collective.easytemplate: lib-depends ====>> [01] Status for build www/py-collective.easytemplate: configure ====>> [01] Status for build www/py-collective.easytemplate: build ====>> [01] Status for build www/py-collective.easytemplate: run-depends ====>> [01] Status for build www/py-collective.easytemplate: stage ====>> [01] Status for build www/py-collective.easytemplate: package ====>> [01] Status for build www/py-collective.easytemplate: install-mtree ====>> [01] Status for build www/py-collective.easytemplate: install ====>> [01] Finished build of www/py-collective.easytemplate: Success As requested previously, please include QA (portlint, poudriere or equiv) outputs as attachments, not inline comments. Thanks! Created attachment 154617 [details]
poudriere and portlint output
Hi guys, sorry for late response. "plone" isn't needed in PKGNAMEPREFIX.
The port builds and installs fine, but it lacks required dependencies, so it's unclear to me how it supposed to work. Here is the dependencies listed in setup.py:
install_requires=['setuptools',
'Jinja2',
'plone.portlet.static',
'collective.templateengines',
'feedparser' # needed by RSS tag, could be softdependency
],
We have no such thing as "collective.templateengines" in the ports tree, so you need port it too to make things work.
Thanks Ruslan. Pending updated patch. Ok just got back off holiday - will look into it. Created attachment 156366 [details]
New shar file (with dependencies in the Makefile this time)
www/py-collective.easytemplate$ portlint -AC looks fine. Need testport again? Yes, would be great. Created attachment 156463 [details]
New shar file
New shar file - fixes dependencies and ordering of categories.
Created attachment 156464 [details]
Combined logfiles for build
Combined logfiles for build (testport) of:
py-collective.easytemplate
py.collective.templateengines
A commit references this bug: Author: rm Date: Mon Jun 1 18:38:26 UTC 2015 New revision: 388249 URL: https://svnweb.freebsd.org/changeset/ports/388249 Log: collective.easytemplate addon for Plone. WWW: https://pypi.python.org/pypi/collective.easytemplate/ PR: 198704 Submitted by: Michelle Sullivan <michelle@sorbs.net> Changes: head/www/Makefile head/www/py-collective.easytemplate/ head/www/py-collective.easytemplate/Makefile head/www/py-collective.easytemplate/distinfo head/www/py-collective.easytemplate/pkg-descr Committed, thank you! The only change I did is fixing collective.templateengines dependency in Makefile, while you set it to collective.easytemplate itself in last shar revision. |
Created attachment 154512 [details] Shar archive of new port. Plone add-on for dynamic templating.